From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:58818 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbZLUTaa (ORCPT ); Mon, 21 Dec 2009 14:30:30 -0500 Date: Mon, 21 Dec 2009 14:17:25 -0500 From: "John W. Linville" To: Gertjan van Wingerde Cc: Pavel Roskin , Markus Baier , linux-wireless@vger.kernel.org Subject: Re: [BISECTED] [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations. Message-ID: <20091221191725.GF4979@tuxdriver.com> References: <1259012694-14869-4-git-send-email-gwingerde@gmail.com> <1259012694-14869-5-git-send-email-gwingerde@gmail.com> <1259012694-14869-6-git-send-email-gwingerde@gmail.com> <1259012694-14869-7-git-send-email-gwingerde@gmail.com> <1259012694-14869-8-git-send-email-gwingerde@gmail.com> <1259012694-14869-9-git-send-email-gwingerde@gmail.com> <4B2E8729.7050501@gmail.com> <20091221013316.nm9belnhywwwsc0w-cebfxv@webmail.spamcop.net> <4B2FA1CF.1010903@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4B2FA1CF.1010903@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Dec 21, 2009 at 05:26:55PM +0100, Gertjan van Wingerde wrote: > On 12/21/09 07:33, Pavel Roskin wrote: > > My debugging shows that the headroom is 0 with the "patch". Without it, > > the headroom is 17 (13 from IEEE80211_TX_STATUS_HEADROOM plus 4 from > > RT2X00_ALIGN_SIZE). > > > > Perhaps non-zero headroom is not handled correctly? > > > > Hmmm, perhaps the problem is that the headroom is not a multiple of 4. > Can you check what happens when you set the extra_tx_headroom fixed to e.g. 20? > > The driver should be able to handle this, but maybe there is something wrong > with the alignment. For the record, I have dropped this patch. Please feel free to resubmit a working version. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.