[PATCH] ath5k: adding LED support for AR5BXB63 cards

[PATCH] ath5k: adding LED support for AR5BXB63 cards

[Luca Verdesca]

With following patch, LED should now work with LiteOn AR5BXB63 mini
pci-e cards.

I hope I made no mistake.

Happy hacking!
Magooz


*** /usr/src/linux/drivers/net/wireless/ath/ath5k/led.c	2009-12-16 16:06:08.000000000 +0100
--- /home/magooz/led.c	2009-12-16 16:10:46.000000000 +0100
***************
*** 53,58 ****
--- 53,61 ----
  
  /* Devices we match on for LED config info (typically laptops) */
  static const struct pci_device_id ath5k_led_devices[] = {
+ 	/* LiteOn AR5BXB63 (magooz@salug.it) */
+ 	{ PCI_SDEVICE(ATHEROS, 0x3067), ATH_LED(3, 0) },
  	/* AR5211 */
  	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5211), ATH_LED(0, 0) },
  	/* HP Compaq nc6xx, nc4000, nx6000 */

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[Bob Copeland]

On Mon, Dec 21, 2009 at 8:21 PM, Luca Verdesca <magooz@salug.it> wrote:
> With following patch, LED should now work with LiteOn AR5BXB63 mini
> pci-e cards.
>
> I hope I made no mistake.
>
> Happy hacking!
> Magooz

Would you mind re-spinning a patch using the subvendor instead of the
Atheros device ID?  For all I know, all of the AR5BXB63s are the same,
but just in case let's stick with subvendor until we know for sure.
You can get the proper numbers by running lspci -vnn as root, and look
at the other stanzas for examples.

Thanks!
-Bob

-- 
Bob Copeland %% www.bobcopeland.com

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[Luca Verdesca]

Il giorno Mon, 21 Dec 2009 22:37:51 -0500
Bob Copeland <me@bobcopeland.com> ha scritto:

> On Mon, Dec 21, 2009 at 8:21 PM, Luca Verdesca <magooz@salug.it>
> wrote:
> > With following patch, LED should now work with LiteOn AR5BXB63 mini
> > pci-e cards.
[CUT]
> Would you mind re-spinning a patch using the subvendor instead of the
> Atheros device ID?  For all I know, all of the AR5BXB63s are the same,
> but just in case let's stick with subvendor until we know for sure.
> You can get the proper numbers by running lspci -vnn as root, and look
> at the other stanzas for examples.
It can seem odd, but actually I used the subvendor ID lspci shows me,
in that patch.

03:00.0 Ethernet controller [0200]: Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)
	Subsystem: Atheros Communications Inc. AR242x 802.11abg Wireless PCI Express Adapter (rev 01) [168c:3067]
[CUT]
	Kernel driver in use: ath5k
	Kernel modules: ath5k

Actually I learned it's a LiteOn by it's MAC address
(00:16:44:xx:xx:xx), because there is no writing on the card but the
model.

> Thanks!
> -Bob
Happy to contribute. :)
Luca [Magooz]

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[John W. Linville]

On Mon, Dec 21, 2009 at 10:37:51PM -0500, Bob Copeland wrote:
> On Mon, Dec 21, 2009 at 8:21 PM, Luca Verdesca <magooz@salug.it> wrote:
> > With following patch, LED should now work with LiteOn AR5BXB63 mini
> > pci-e cards.
> >
> > I hope I made no mistake.
> >
> > Happy hacking!
> > Magooz
> 
> Would you mind re-spinning a patch using the subvendor instead of the
> Atheros device ID?  For all I know, all of the AR5BXB63s are the same,
> but just in case let's stick with subvendor until we know for sure.
> You can get the proper numbers by running lspci -vnn as root, and look
> at the other stanzas for examples.

Please also take note of the following guidelines for posting patches:

	http://www.linux-mips.org/wiki/The_perfect_patch

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[Bob Copeland]

On Tue, Dec 22, 2009 at 12:02:45PM +0100, Luca Verdesca wrote:
> It can seem odd, but actually I used the subvendor ID lspci shows me,
> in that patch.
> 
> 03:00.0 Ethernet controller [0200]: Atheros Communications Inc. AR5001 Wireless Network Adapter [168c:001c] (rev 01)
> 	Subsystem: Atheros Communications Inc. AR242x 802.11abg Wireless PCI Express Adapter (rev 01) [168c:3067]

Huh, interesting.  Well 0x3067 isn't some other vendor device id, and I did
miss that you used PCI_SDEVICE() -- so, nevermind :)

> Happy to contribute. :)
> Luca [Magooz]

In order to be included, you should prepare a patch using diff -up, and
add your Signed-off-by (see Documentation/SubmittingPatches).  If you
do that you can also add my:

Acked-by: Bob Copeland <me@bobcopeland.com>

and copy John Linville on the patch for inclusion.

-- 
Bob Copeland %% www.bobcopeland.com

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[Luca Verdesca]

With following patch, LED should now work with LiteOn AR5BXB63 mini
pci-e cards.

Signed-off-by: Luca Verdesca <magooz@salug.it>
Acked-by: Bob Copeland <me@bobcopeland.com>
Cc: John Linville <linville@tuxdriver.com>
---
 home/magooz/led.c |    2 ++
 1 file changed, 2 insertions(+)

--- /usr/src/linux/drivers/net/wireless/ath/ath5k/led.c	2009-12-22 16:37:42.000000000 +0100
+++ /home/magooz/led.c	2009-12-22 16:38:14.000000000 +0100
@@ -75,6 +75,8 @@ static const struct pci_device_id ath5k_
 	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137a), ATH_LED(3, 1) },
 	/* HP Compaq C700 (nitrousnrg@gmail.com) */
 	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
+	/* LiteOn AR5BXB63 (magooz@salug.it) */
+	{ PCI_SDEVICE(ATHEROS, 0x3067), ATH_LED(3, 0) },
 	/* IBM-specific AR5212 (all others) */
 	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
 	{ }

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[John W. Linville]

On Tue, Dec 22, 2009 at 06:10:01PM +0100, Luca Verdesca wrote:
> With following patch, LED should now work with LiteOn AR5BXB63 mini
> pci-e cards.
> 
> Signed-off-by: Luca Verdesca <magooz@salug.it>
> Acked-by: Bob Copeland <me@bobcopeland.com>
> Cc: John Linville <linville@tuxdriver.com>
> ---
>  home/magooz/led.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- /usr/src/linux/drivers/net/wireless/ath/ath5k/led.c	2009-12-22 16:37:42.000000000 +0100
> +++ /home/magooz/led.c	2009-12-22 16:38:14.000000000 +0100
> @@ -75,6 +75,8 @@ static const struct pci_device_id ath5k_
>  	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137a), ATH_LED(3, 1) },
>  	/* HP Compaq C700 (nitrousnrg@gmail.com) */
>  	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> +	/* LiteOn AR5BXB63 (magooz@salug.it) */
> +	{ PCI_SDEVICE(ATHEROS, 0x3067), ATH_LED(3, 0) },
>  	/* IBM-specific AR5212 (all others) */
>  	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
>  	{ }

Did you compile this?  Perhaps you meant to use ATH_SDEVICE instead?
Of course, it still wouldn't be quite right AFAICT...

Also, please make sure that your patch can be applied with "patch -p1".

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards

[Luca Verdesca]

Il giorno Mon, 28 Dec 2009 16:12:58 -0500
"John W. Linville" <linville@tuxdriver.com> ha scritto:

> On Tue, Dec 22, 2009 at 06:10:01PM +0100, Luca Verdesca wrote:
> > With following patch, LED should now work with LiteOn AR5BXB63 mini
> > pci-e cards.
> > 
> > Signed-off-by: Luca Verdesca <magooz@salug.it>
> > Acked-by: Bob Copeland <me@bobcopeland.com>
> > Cc: John Linville <linville@tuxdriver.com>
> > ---
> >  home/magooz/led.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > --- /usr/src/linux/drivers/net/wireless/ath/ath5k/led.c
> > 2009-12-22 16:37:42.000000000 +0100 +++ /home/magooz/led.c
> > 2009-12-22 16:38:14.000000000 +0100 @@ -75,6 +75,8 @@ static const
> > struct pci_device_id ath5k_ { ATH_SDEVICE(PCI_VENDOR_ID_HP,
> > 0x0137a), ATH_LED(3, 1) }, /* HP Compaq C700 (nitrousnrg@gmail.com)
> > */ { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> > +	/* LiteOn AR5BXB63 (magooz@salug.it) */
> > +	{ PCI_SDEVICE(ATHEROS, 0x3067), ATH_LED(3, 0) },
> >  	/* IBM-specific AR5212 (all others) */
> >  	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM),
> > ATH_LED(0, 0) }, { }
> 
> Did you compile this?  Perhaps you meant to use ATH_SDEVICE instead?
Damn, you're right. I posted a wrong, patch, the first try I made.
> Of course, it still wouldn't be quite right AFAICT...
Can I ask you why?
> 
> Also, please make sure that your patch can be applied with "patch
> -p1".
I re-created the patch, so it should be right, by now. I'll post it in
a new mail.
> 
> Thanks,
> 
> John
Sorry for the inconvenience, and thanks for clarifications.
Luca