Re: [PATCH][resend with linux-wireless] b43: N-PHY: clean table init, check PHY rev

["John W. Linville" <linville@tuxdriver.com>]

On Wed, Dec 23, 2009 at 01:01:58PM +0100, Rafał Miłecki wrote:
> It's just compilation-tested as I don't own N-PHY device yet (should receive
> one for Christmas). Of course I enabled N-PHY in Kconfig.
> 
> I already sent this to bcm43xx-dev but didn't get any review. Michael told
> me to send it to you John and to linux-wireless. Is there anyone how could
> review/ack my patch?
> 
> 
> From 6800722c2fda0e302d7c759a5f2a993503b6581a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>
> Date: Tue, 22 Dec 2009 02:27:21 +0100
> Subject: [PATCH] b43: N-PHY: clean table init, check PHY rev
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Move table init to tables_nphy.c, detect newer PHY which use different init
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> drivers/net/wireless/b43/phy_n.c       |   43 ++++------------------------
> drivers/net/wireless/b43/tables_nphy.c |   48
> ++++++++++++++++++++++++++++++++
> drivers/net/wireless/b43/tables_nphy.h |    4 ++-
> 3 files changed, 58 insertions(+), 37 deletions(-)

Well, the patch is fairly clearly whitespace-damaged.  Perhaps that
is a product of how you forwarded it to linux-wireless?

Other than that, it looks like you are mostly just moving code around.
That's fine, but there doesn't seem to be a lot of point in it
unless the rev 3+ stuff is coming soon?  It probably doesn't harm
much either way...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.