linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Luca Verdesca <magooz@salug.it>
Cc: Bob Copeland <me@bobcopeland.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: adding LED support for AR5BXB63 cards
Date: Mon, 28 Dec 2009 16:12:58 -0500	[thread overview]
Message-ID: <20091228211258.GA13285@tuxdriver.com> (raw)
In-Reply-To: <20091222181001.5c1077b8@magooz.no-ip.org>

On Tue, Dec 22, 2009 at 06:10:01PM +0100, Luca Verdesca wrote:
> With following patch, LED should now work with LiteOn AR5BXB63 mini
> pci-e cards.
> 
> Signed-off-by: Luca Verdesca <magooz@salug.it>
> Acked-by: Bob Copeland <me@bobcopeland.com>
> Cc: John Linville <linville@tuxdriver.com>
> ---
>  home/magooz/led.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- /usr/src/linux/drivers/net/wireless/ath/ath5k/led.c	2009-12-22 16:37:42.000000000 +0100
> +++ /home/magooz/led.c	2009-12-22 16:38:14.000000000 +0100
> @@ -75,6 +75,8 @@ static const struct pci_device_id ath5k_
>  	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137a), ATH_LED(3, 1) },
>  	/* HP Compaq C700 (nitrousnrg@gmail.com) */
>  	{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> +	/* LiteOn AR5BXB63 (magooz@salug.it) */
> +	{ PCI_SDEVICE(ATHEROS, 0x3067), ATH_LED(3, 0) },
>  	/* IBM-specific AR5212 (all others) */
>  	{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
>  	{ }

Did you compile this?  Perhaps you meant to use ATH_SDEVICE instead?
Of course, it still wouldn't be quite right AFAICT...

Also, please make sure that your patch can be applied with "patch -p1".

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2009-12-28 21:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22  1:21 [PATCH] ath5k: adding LED support for AR5BXB63 cards Luca Verdesca
2009-12-22  3:37 ` Bob Copeland
2009-12-22 11:02   ` Luca Verdesca
2009-12-22 14:28     ` Bob Copeland
2009-12-22 17:10       ` Luca Verdesca
2009-12-28 21:12         ` John W. Linville [this message]
2010-01-02 15:33           ` Luca Verdesca
2009-12-22 14:18   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091228211258.GA13285@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=magooz@salug.it \
    --cc=me@bobcopeland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).