linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	"bcm43xx-dev@lists.berlios.de" <bcm43xx-dev@lists.berlios.de>
Subject: Re: [PATCH 2/5] b43: N-PHY: b43_nphy_get_tx_gains
Date: Wed, 6 Jan 2010 20:36:53 +0100	[thread overview]
Message-ID: <201001062036.55758.mb@bu3sch.de> (raw)
In-Reply-To: <b170af451001061129n59357edehc1f2328fb10846f6@mail.gmail.com>

On Wednesday 06 January 2010 20:29:36 Rafał Miłecki wrote:
> > You may read Documentation/SubmittingPatches and format your future
> > patches according to that.
> 
> Well, that's really poor joke :| Manually creating .orig files, using
> "diff -up" and so dropping local commits "strategy"...? Er, I don't
> think I'll use this one.

Nobody said you need to fix your internal workflow. Why would anybody care
_how_ you generate your patches?
You could manually type them into your cellphone with T9. If that it results
in a properly formated patch in the end, nobody would complain.

So yes, reading other people's patches probably is a good idea to start with.

In general only put stuff into the mail that you want to show up in the commit
message. (If you want to have additional stuff that doesn't show up in the commit
message, you can use the "---" delimiter. But that's documented elsewhere so
I don't have to explain that here...)

-- 
Greetings, Michael

  reply	other threads:[~2010-01-06 19:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 15:40 [PATCH 2/5] b43: N-PHY: b43_nphy_get_tx_gains Rafał Miłecki
2010-01-06 17:26 ` Luis R. Rodriguez
2010-01-06 18:18   ` Rafał Miłecki
2010-01-06 18:22     ` Michael Buesch
2010-01-06 19:29       ` Rafał Miłecki
2010-01-06 19:36         ` Michael Buesch [this message]
2010-01-06 19:41           ` Rafał Miłecki
2010-01-06 19:51             ` Michael Buesch
2010-01-06 20:15               ` Rafał Miłecki
2010-01-06 20:57     ` [PATCH 2/5] b43: N-PHY: add b43_nphy_get_tx_gains (V2) Rafał Miłecki
2010-01-06 21:23       ` Larry Finger
2010-01-06 21:29         ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001062036.55758.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).