From: Lennert Buytenhek <buytenh@wantstofly.org>
To: sedat.dilek@gmail.com
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2.6.33] mac80211: fix skb buffering issue
Date: Thu, 7 Jan 2010 05:10:18 +0100 [thread overview]
Message-ID: <20100107041018.GG1735@mail.wantstofly.org> (raw)
In-Reply-To: <2d0a357f1001061431i7b306da7v2bf8717a3d3ab0cc@mail.gmail.com>
On Wed, Jan 06, 2010 at 11:31:10PM +0100, Sedat Dilek wrote:
> Why are there two different ".ndo_set_mac_address" in [1]?
>
> static const struct net_device_ops ieee80211_dataif_ops = {
> ...
> .ndo_set_mac_address = ieee80211_change_mac,
> + .ndo_select_queue = ieee80211_netdev_select_queue,
> };
>
> static const struct net_device_ops ieee80211_monitorif_ops = {
> ...
> .ndo_set_mac_address = eth_mac_addr,
> + .ndo_select_queue = ieee80211_monitor_select_queue,
> };
Because a different queue selection algorithm is needed for
monitor (ieee80211_monitor_select_queue) and non-monitor
(ieee80211_netdev_select_queue) interfaces. The commit message
mentions this.
next prev parent reply other threads:[~2010-01-07 4:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 17:00 [PATCH 2.6.33] mac80211: fix skb buffering issue Johannes Berg
2010-01-05 17:16 ` John W. Linville
2010-01-05 18:36 ` Lennert Buytenhek
2010-01-05 19:07 ` Felix Fietkau
2010-01-05 19:36 ` Lennert Buytenhek
2010-01-06 11:32 ` Lennert Buytenhek
2010-01-06 5:30 ` Larry Finger
2010-01-06 11:05 ` Johannes Berg
2010-01-06 18:16 ` Larry Finger
2010-01-06 11:33 ` Lennert Buytenhek
2010-01-06 21:26 ` Thomas Backlund
2010-01-06 21:51 ` Johannes Berg
2010-01-06 22:03 ` Felix Fietkau
2010-01-06 22:39 ` Thomas Backlund
2010-01-06 23:19 ` Thomas Backlund
2010-01-07 6:57 ` Johannes Berg
2010-01-07 10:41 ` Thomas Backlund
2010-01-06 22:31 ` Sedat Dilek
2010-01-07 4:10 ` Lennert Buytenhek [this message]
2010-01-07 9:24 ` Sedat Dilek
2010-01-07 14:01 ` mac80211: fix queue selection for packets injected via monitor interface Lennert Buytenhek
2010-01-07 15:45 ` Luis R. Rodriguez
2010-01-07 15:47 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107041018.GG1735@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).