From: Michael Buesch <mb@bu3sch.de>
To: bcm43xx-dev@lists.berlios.de
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3
Date: Sun, 10 Jan 2010 23:38:26 +0100 [thread overview]
Message-ID: <201001102338.28721.mb@bu3sch.de> (raw)
In-Reply-To: <op.u6b70wtk9lhzdc@linux-g0th.site>
On Sunday 10 January 2010 23:13:34 Rafał Miłecki wrote:
> + s32 results_min[4];
> + u8 vcm_final[4];
> + s32 results[4][4];
> + s32 miniq[4][2];
> + memset(results_min, 0, sizeof(s32) * 4);
> + memset(vcm_final, 0, sizeof(u8) * 4);
> + memset(results, 0, sizeof(s32) * 4 * 4);
> + memset(miniq, 0, sizeof(s32) * 4 * 2);
Just initialize the variables to zero instead of doing a memset:
+ s32 results_min[4] = { 0, };
+ u8 vcm_final[4] = { 0, };
+ s32 results[4][4] = { 0, };
+ s32 miniq[4][2] = { 0, };
> + b43_radio_maskset(dev, B2055_C1_PD_RSSIMISC, 0xF8, 0);
> + b43_radio_maskset(dev, B2055_C2_PD_RSSIMISC, 0xF8, 0);
If you don't set anything, you can use
b43_radio_mask();
--
Greetings, Michael.
next prev parent reply other threads:[~2010-01-10 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 22:13 [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3 Rafał Miłecki
2010-01-10 22:38 ` Michael Buesch [this message]
2010-01-11 21:13 ` Rafał Miłecki
2010-01-11 22:13 ` Michael Buesch
2010-01-11 22:19 ` Johannes Berg
2010-01-11 22:23 ` Michael Buesch
2010-01-11 22:27 ` Rafał Miłecki
2010-01-11 22:42 ` Michael Buesch
2010-01-11 22:43 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001102338.28721.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).