From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: mac80211: fix queue selection for data frames on monitor interfaces
Date: Tue, 12 Jan 2010 10:37:34 +0100 [thread overview]
Message-ID: <20100112093733.GA2548@mail.wantstofly.org> (raw)
In-Reply-To: <4B4ABB54.7030600@openwrt.org>
On Mon, Jan 11, 2010 at 06:47:00AM +0100, Felix Fietkau wrote:
> When ieee80211_monitor_select_queue encounters data frames, it selects
> the WMM AC based on skb->priority and assumes that skb->priority
> contains a valid 802.1d tag. However this assumption is incorrect, since
> ieee80211_select_queue has not been called at this point.
> If skb->priority > 7, an array overrun occurs, which could lead to
> invalid values, resulting in crashes in the tx path.
What you describe here was already reported and fixed:
http://marc.info/?l=linux-wireless&m=126287290723244&w=2
http://git.kernel.org/?p=linux/kernel/git/linville/wireless-2.6.git;a=commit;h=045cfb71a3901005bf6dcedae98cecb3360a0bfc
Your commit message could at least acknowledge this. I.e. write
that the existing fix doesn't handle QoS data frames in the optimal
way, and then mention this:
> Fix this by setting skb->priority based on the 802.11 header for QoS
> frames and using the default AC for all non-QoS frames.
next prev parent reply other threads:[~2010-01-12 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 5:47 mac80211: fix queue selection for data frames on monitor interfaces Felix Fietkau
2010-01-11 16:03 ` Luis R. Rodriguez
2010-01-12 3:02 ` Felix Fietkau
2010-01-12 9:37 ` Lennert Buytenhek [this message]
2010-01-12 11:51 ` Felix Fietkau
2010-01-12 16:51 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112093733.GA2548@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).