From: Michael Buesch <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
"bcm43xx-dev@lists.berlios.de" <bcm43xx-dev@lists.berlios.de>
Subject: Re: [PATCH 1/4] b43: N-PHY: add writing one element tables
Date: Sun, 17 Jan 2010 23:45:52 +0100 [thread overview]
Message-ID: <201001172345.54110.mb@bu3sch.de> (raw)
In-Reply-To: <op.u6o7s9rq9lhzdc@linux-g0th.site>
On Sunday 17 January 2010 23:37:50 Rafał Miłecki wrote:
> @@ -1895,14 +1880,12 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
> b43_phy_write(dev, B43_NPHY_IQLOCAL_CMDNNUM, tmp);
>
> if (type == 1 || type == 3 || type == 4) {
> - /* TODO: Read an N PHY Table with ID 15,
> - length 1, offset 69 + core,
> - width 16, and data pointer buffer */
> + b43_ntab_write(dev, B43_NTAB16(15, 69 + core),
> + buffer[0]);
> diq_start = buffer[0];
> buffer[0] = 0;
> - /* TODO: Write an N PHY Table with ID 15,
> - length 1, offset 69 + core, width 16,
> - and data of 0 */
> + b43_ntab_write(dev, B43_NTAB16(15, 69 + core),
> + 0);
> }
>
> b43_phy_write(dev, B43_NPHY_IQLOCAL_CMD, cmd);
What is this supposed to do? It writes a value to a table entry and immediately
clobbers the entry with 0. This doesn't make any sense.
--
Greetings, Michael.
next prev parent reply other threads:[~2010-01-17 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 22:37 [PATCH 1/4] b43: N-PHY: add writing one element tables Rafał Miłecki
2010-01-17 22:45 ` Michael Buesch [this message]
2010-01-17 22:59 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001172345.54110.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).