From: Fabio Rossi <rossi.f@inwind.it>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH 4/5] mac80211: move control.hw_key assignment
Date: Sat, 23 Jan 2010 16:22:03 +0100 [thread overview]
Message-ID: <201001231622.03394.rossi.f@inwind.it> (raw)
In-Reply-To: <20100117004825.177097479@sipsolutions.net>
On Sunday 17 January 2010 01:47:58 Johannes Berg wrote:
> When mac80211 asks a driver to encrypt a frame, it
> must assign the control.hw_key pointer for it to
> know which key to use etc. Currently, mac80211 does
> this whenever it would software-encrypt a frame.
>
> Change the logic of this code to assign the hw_key
> pointer when selecting the key, and later check it
> when deciding whether to encrypt the frame or let
> it be encrypted by the hardware. This allows us to
> later simply skip the encryption function since it
> no longer modifies the TX control.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Hi Johannes,
this patch breaks my wireless connection. I'm able to authenticate and
associate to my AP but I can't use the connection, a simple ping towards my AP
doesn't work. I bisected the problem and your patch is the bad commit.
I have the latest wireless-testing.git (v2.6.33-rc5-47285-g96ada3c). After
having removed all the commits related to this patch, i.e.
- commit f12553ebe045a8a40ab33fa500fb57d10706e226
- commit e4fca007b06165900d0e44e8d5e251376819bf5d
- commit 813d76694043d00b59475baa1fbfaf54a2eb7fad
the connection is working again.
Fabio
next prev parent reply other threads:[~2010-01-23 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 0:47 [PATCH 0/5] mac80211 re-transmission repair Johannes Berg
2010-01-17 0:47 ` [PATCH 1/5] mac80211: move and rename misc tx handler Johannes Berg
2010-01-17 0:47 ` [PATCH 2/5] mac80211: clear TX control on filtered frames Johannes Berg
2010-01-17 0:47 ` [PATCH 3/5] mac80211: remove useless setting of IEEE80211_TX_INTFL_DONT_ENCRYPT Johannes Berg
2010-01-17 0:47 ` [PATCH 4/5] mac80211: move control.hw_key assignment Johannes Berg
2010-01-23 15:22 ` Fabio Rossi [this message]
2010-01-24 11:29 ` Johannes Berg
2010-01-25 22:07 ` Fabio Rossi
2010-01-24 18:26 ` Maxim Levitsky
2010-01-17 0:47 ` [PATCH 5/5] mac80211: re-enable re-transmission of filtered frames Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001231622.03394.rossi.f@inwind.it \
--to=rossi.f@inwind.it \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).