From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] b43: make cordic common (LP-PHY and N-PHY need it)
Date: Mon, 25 Jan 2010 17:19:35 -0500 [thread overview]
Message-ID: <20100125221935.GC14699@tuxdriver.com> (raw)
In-Reply-To: <201001251953.21692.mb@bu3sch.de>
On Mon, Jan 25, 2010 at 07:53:19PM +0100, Michael Buesch wrote:
> On Monday 25 January 2010 19:36:27 Rafał Miłecki wrote:
> > W dniu 25 stycznia 2010 19:35 użytkownik Rafał Miłecki
> > <zajec5@gmail.com> napisał:
> > > 2010/1/25 Michael Buesch <mb@bu3sch.de>:
> > >> On Monday 25 January 2010 18:59:59 Rafał Miłecki wrote:
> > >>> +/* Complex number using 2 32-bit signed integers */
> > >>> +typedef struct { s32 i, q; } b43_c32;
> > >>
> > >> No typedef. ever.
> > >
> > > Well, I just copied (Gabor's?) code here. But of course I can fix this
> > > by the way, no problem :)
>
> Yeah, I saw that. We can fix it while we're at it. ;)
>
> > > Just read about typedef in Linux Kernel Coding Style, didn't know
> > > about this earlier. Thanks for pointing.
> >
> > Is this OK to fix this in separated patch? Or should I modify this set
> > of patches?
>
> Well, as you touch any reference to the typedef anyway (you renamed it),
> you can just put the keyword "struct" in front of the references and no separate patch is needed.
> It won't even grow your current patch in the number of changed lines.
I took care of these modifications to the original patch...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-01-25 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 17:59 [PATCH 0/4] more N-PHY, cordic stuff Rafał Miłecki
2010-01-25 17:59 ` [PATCH 1/4] b43: N-PHY: fix one bit off in parsing RF Ctrl Override arguments Rafał Miłecki
2010-01-25 17:59 ` [PATCH 2/4] b43: make cordic common (LP-PHY and N-PHY need it) Rafał Miłecki
2010-01-25 18:32 ` Michael Buesch
2010-01-25 18:35 ` Rafał Miłecki
2010-01-25 18:36 ` Rafał Miłecki
2010-01-25 18:53 ` Michael Buesch
2010-01-25 22:19 ` John W. Linville [this message]
2010-01-25 23:17 ` Rafał Miłecki
2010-01-25 18:00 ` [PATCH 3/4] b43: update cordic code to match current specs Rafał Miłecki
2010-01-25 18:00 ` [PATCH 4/4] b43: N-PHY: use cordic to generate samples Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125221935.GC14699@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).