Re: [PATCH] rtl8180: implement get_tsf op for mac80211

["John W. Linville" <linville@tuxdriver.com>]

On Tue, Jan 26, 2010 at 11:53:38PM +0100, Gábor Stefanik wrote:
> On Tue, Jan 26, 2010 at 10:22 PM, John W. Linville
> <linville@tuxdriver.com> wrote:
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > ---
> >  drivers/net/wireless/rtl818x/rtl8180_dev.c |   15 +++++++++++++++
> >  1 files changed, 15 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/wireless/rtl818x/rtl8180_dev.c b/drivers/net/wireless/rtl818x/rtl8180_dev.c
> > index 5a2b719..8dbb504 100644
> > --- a/drivers/net/wireless/rtl818x/rtl8180_dev.c
> > +++ b/drivers/net/wireless/rtl818x/rtl8180_dev.c
> > @@ -761,6 +761,20 @@ static void rtl8180_configure_filter(struct ieee80211_hw *dev,
> >        rtl818x_iowrite32(priv, &priv->map->RX_CONF, priv->rx_conf);
> >  }
> >
> > +static u64 rtl8180_get_tsf(struct ieee80211_hw *dev)
> > +{
> > +       struct rtl8180_priv *priv = dev->priv;
> > +       u32 tsftl;
> > +       u64 tsft;
> > +
> > +       tsftl = rtl818x_ioread32(priv, &priv->map->TSFT[0]);
> > +       tsft = rtl818x_ioread32(priv, &priv->map->TSFT[1]);
> > +       tsft <<= 32;
> > +       tsft |= tsftl;
> > +
> > +       return tsft;
> > +}
> 
> Why not:
> 
> struct rtl8180_priv *priv = dev->priv;
> u64 tsft;
> 
> tsft = rtl818x_ioread32(priv, &priv->map->TSFT[0]);
> tfst |= rtl818x_ioread32(priv, &priv->map->TSFT[1]) << 32;
> 
> return tsft;

What difference does it make?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.