AW: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

AW: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

[Joerg Pommnitz]

John,
thanks for the quick response. The patch works fine for me. Feel free to add a

Tested-by: "Joerg Pommnitz" <pommnitz@yahoo.com>

-- 
Regards
       Joerg


--- John W. Linville <linville@tuxdriver.com> schrieb am Mi, 27.1.2010:

> Von: John W. Linville <linville@tuxdriver.com>
> Betreff: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'
> An: linux-wireless@vger.kernel.org
> CC: "Joerg Pommnitz" <pommnitz@yahoo.com>, "John W. Linville" <linville@tuxdriver.com>
> Datum: Mittwoch, 27. Januar 2010, 15:44
> Signed-off-by: John W. Linville
> <linville@tuxdriver.com>
> ---
> Haven't had a chance to test yet, but I suspect this fixes
> the issue...?
> 
>  net/wireless/wext-compat.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/wireless/wext-compat.c
> b/net/wireless/wext-compat.c
> index 966d2f0..b17eeae 100644
> --- a/net/wireless/wext-compat.c
> +++ b/net/wireless/wext-compat.c
> @@ -1214,7 +1214,7 @@ int cfg80211_wext_siwrate(struct
> net_device *dev,
>  
>      memset(&mask, 0, sizeof(mask));
>      fixed = 0;
> -    maxrate = 0;
> +    maxrate = (u32)-1;
>  
>      if (rate->value < 0) {
>          /* nothing */
> -- 
> 1.6.2.5
> 
>


__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. 
http://mail.yahoo.com 

Re: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

[John W. Linville]

On Wed, Jan 27, 2010 at 07:51:06AM -0800, Joerg Pommnitz wrote:
> John,
> thanks for the quick response. The patch works fine for me. Feel free to add a
> 
> Tested-by: "Joerg Pommnitz" <pommnitz@yahoo.com>

Joerg,

I still haven't had time for a reboot. :-(  I wonder if you tested
to make sure that using "fixed" or just a rate by itself still works
properly too?

Thanks!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

[Joerg Pommnitz]

John,
I switched between a fixed data rate and automatic selection. Selecting a
fixed data rate seems to work fine. I can't be 100% sure, because the
RC algorithm might have decided to pick exactly this rate, but this would
be very unlikely. Switching back to auto looks good, too.

-- 
Regards
       Joerg


--- John W. Linville <linville@tuxdriver.com> schrieb am Mi, 27.1.2010:

> Von: John W. Linville <linville@tuxdriver.com>
> Betreff: Re: [PATCH] cfg80211: fix wext-compat for setting rate to 'auto'
> An: "Joerg Pommnitz" <pommnitz@yahoo.com>
> CC: linux-wireless@vger.kernel.org
> Datum: Mittwoch, 27. Januar 2010, 17:17
> On Wed, Jan 27, 2010 at 07:51:06AM
> -0800, Joerg Pommnitz wrote:
> > John,
> > thanks for the quick response. The patch works fine
> for me. Feel free to add a
> > 
> > Tested-by: "Joerg Pommnitz" <pommnitz@yahoo.com>
> 
> Joerg,
> 
> I still haven't had time for a reboot. :-(  I wonder
> if you tested
> to make sure that using "fixed" or just a rate by itself
> still works
> properly too?
> 
> Thanks!
> 
> John
> -- 
> John W. Linville       
> Someday the world will need a hero, and you
> linville@tuxdriver.com   
>         might be all we
> have.  Be ready.
> 

__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. 
http://mail.yahoo.com 

mac80211: Open bug in current wireless-testing

[Joerg Pommnitz]

Hello all,
some time ago I reported that it is currently impossible to change a manually selected data rate back to the automatic rate selection. This bug is still present and is easy to reproduce:

iwconfig wlan0 rate 54M
iwconfig wlan0 rate auto

I know that the wireless extensions are deprecated, but until iw supports manual rate selection, iwconfig is what I have to use.

-- 
Regards
       Joerg

__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. 
http://mail.yahoo.com 

[PATCH] cfg80211: fix wext-compat for setting rate to 'auto'

[John W. Linville]

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Haven't had a chance to test yet, but I suspect this fixes the issue...?

 net/wireless/wext-compat.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c
index 966d2f0..b17eeae 100644
--- a/net/wireless/wext-compat.c
+++ b/net/wireless/wext-compat.c
@@ -1214,7 +1214,7 @@ int cfg80211_wext_siwrate(struct net_device *dev,
 
 	memset(&mask, 0, sizeof(mask));
 	fixed = 0;
-	maxrate = 0;
+	maxrate = (u32)-1;
 
 	if (rate->value < 0) {
 		/* nothing */
-- 
1.6.2.5