From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Pavel Roskin <proski@gnu.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: fix access to freed data on unload
Date: Mon, 1 Feb 2010 15:36:38 -0500 [thread overview]
Message-ID: <20100201203637.GE4952@tuxdriver.com> (raw)
In-Reply-To: <43e72e891002011011h4714ecddrb9421a877832bffd@mail.gmail.com>
On Mon, Feb 01, 2010 at 10:11:54AM -0800, Luis R. Rodriguez wrote:
> On Sat, Jan 30, 2010 at 6:37 PM, Pavel Roskin <proski@gnu.org> wrote:
> > Calling ath_bus_cleanup() after ieee80211_free_hw() resulted in acc=
ess
> > to common->bus_ops, which is already freed as part of the device da=
ta.
> >
> > Remove the cleanup field in struct ath_bus_ops, as it was never use=
d
> > properly. =A0Remove ath_bus_cleanup(). =A0Merge cleanup functions i=
n place
> > of the ath_bus_cleanup() calls. =A0Take care not to use any device =
data
> > after ieee80211_free_hw().
> >
> > Signed-off-by: Pavel Roskin <proski@gnu.org>
> > ---
> >
> > The bug was causing a hang on a kernel with most debugging options
> > enabled. =A0I think the fix is important and simple enough for stab=
le
> > kernels. =A0I wish I could make the patch smaller, but I didn't wan=
t to
> > leave unused and dangerous fields and functions.
> >
> > ath9k was tested on the PCI bus. =A0ath9k on AHB was compile tested=
=2E
> > ath5k and ar9170 use struct ath_bus_ops, but don't use the cleanup
> > field, so they are not affected.
>=20
> Thanks, can you please resend with a Cc: stable@kernel.org on the com=
mit log?
Doesn't look to me like the patch even applies to 2.6.33...?
--=20
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-01 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 2:37 [PATCH] ath9k: fix access to freed data on unload Pavel Roskin
2010-02-01 18:11 ` Luis R. Rodriguez
2010-02-01 20:36 ` John W. Linville [this message]
2010-02-01 21:32 ` Luis R. Rodriguez
2010-02-01 21:59 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201203637.GE4952@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).