[PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[shanyu.zhao]

From: Shanyu Zhao <shanyu.zhao@intel.com>

Need to set bssid to NULL in cfg80211's SIOCIWESSID function, otherwise
after "iwconfig wlanx ap <mac>", the "iwconfig wlanx essid" won't work.

Cc: stable@kernel.org

Signed-off-by: Shanyu Zhao <shanyu.zhao@intel.com>
---
 net/wireless/wext-sme.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c
index eede356..5a67dd5 100644
--- a/net/wireless/wext-sme.c
+++ b/net/wireless/wext-sme.c
@@ -194,6 +194,7 @@ int cfg80211_mgd_wext_siwessid(struct net_device *dev,
 	wdev->wext.connect.ssid = wdev->wext.ssid;
 	memcpy(wdev->wext.ssid, ssid, len);
 	wdev->wext.connect.ssid_len = len;
+	wdev->wext.connect.bssid = NULL;
 
 	wdev->wext.connect.crypto.control_port = false;
 
-- 
1.6.0.4

Re: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Fri, 2010-01-29 at 15:39 -0800, shanyu.zhao@intel.com wrote:
> From: Shanyu Zhao <shanyu.zhao@intel.com>
> 
> Need to set bssid to NULL in cfg80211's SIOCIWESSID function, otherwise
> after "iwconfig wlanx ap <mac>", the "iwconfig wlanx essid" won't work.
> 
> Cc: stable@kernel.org
> 
> Signed-off-by: Shanyu Zhao <shanyu.zhao@intel.com>
> ---
>  net/wireless/wext-sme.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c
> index eede356..5a67dd5 100644
> --- a/net/wireless/wext-sme.c
> +++ b/net/wireless/wext-sme.c
> @@ -194,6 +194,7 @@ int cfg80211_mgd_wext_siwessid(struct net_device *dev,
>  	wdev->wext.connect.ssid = wdev->wext.ssid;
>  	memcpy(wdev->wext.ssid, ssid, len);
>  	wdev->wext.connect.ssid_len = len;
> +	wdev->wext.connect.bssid = NULL;

This is incorrect. If you want to connect to an AP with the SSID "foo"
and the BSSID "00:...:ff" you need to make two calls, e.g.

iwconfig wlan0 essid "foo"
iwconfig wlan0 ap "00:...:ff"

Your patch disables that functionality.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

RE: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[Zhao, Shanyu]

DQpBY3R1YWxseSBJIGRvbid0IHRoaW5rIG15IHBhdGNoIGRpc2FibGVzIHRoYXQgZnVuY3Rpb25h
bGl0eS4gSWYgdGhlcmUncmUgbXVsdGlwbGUgQVAgd2l0aCB0aGUgc2FtZSBlc3NpZCAiZm9vIiBh
bmQgb25lIG9mIHRoZW0gaGFzIE1BQyAiMDA6Li4uOmZmIiwgdGhlbjoNCg0KaXdjb25maWcgd2xh
bjAgZXNzaWQgImZvbyINClRoaXMgd2lsbCBtYWtlIHRoZSBzdGF0aW9uIGFzc29jaWF0ZSB3aXRo
IHRoZSBmaXJzdCBBUCB3aXRoIGVzc2lkICJmb28iLg0KDQppd2NvbmZpZyB3bGFuMCBhcCAiMDA6
Li4uOmZmIg0KVGhpcyB3aWxsIGRpc2Fzc29jaWF0ZSBmcm9tIHRoZSBwcmV2aW91cyBBUCwgYW5k
IHRoZW4gYXNzb2NpYXRlIHdpdGggdGhlIGZpcnN0IEFQIHdpdGggTUFDICIwMDouLi46ZmYiLg0K
DQpBbSBJIG1pc3NpbmcgYW55dGhpbmcgaGVyZT8NCg0KVGhhbmtzLA0KU2hhbnl1DQoNCi0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBKb2hhbm5lcyBCZXJnIFttYWlsdG86am9oYW5u
ZXNAc2lwc29sdXRpb25zLm5ldF0gDQpTZW50OiBTYXR1cmRheSwgSmFudWFyeSAzMCwgMjAxMCAx
MjozNyBBTQ0KVG86IFpoYW8sIFNoYW55dQ0KQ2M6IGxpbnV4LXdpcmVsZXNzQHZnZXIua2VybmVs
Lm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCAxLzFdIGNmZzgwMjExOiB3ZXh0OiBzZXQgYnNzaWQg
dG8gTlVMTCBpbiBTSU9DSVdFU1NJRA0KDQpPbiBGcmksIDIwMTAtMDEtMjkgYXQgMTU6MzkgLTA4
MDAsIHNoYW55dS56aGFvQGludGVsLmNvbSB3cm90ZToNCj4gRnJvbTogU2hhbnl1IFpoYW8gPHNo
YW55dS56aGFvQGludGVsLmNvbT4NCj4gDQo+IE5lZWQgdG8gc2V0IGJzc2lkIHRvIE5VTEwgaW4g
Y2ZnODAyMTEncyBTSU9DSVdFU1NJRCBmdW5jdGlvbiwgb3RoZXJ3aXNlDQo+IGFmdGVyICJpd2Nv
bmZpZyB3bGFueCBhcCA8bWFjPiIsIHRoZSAiaXdjb25maWcgd2xhbnggZXNzaWQiIHdvbid0IHdv
cmsuDQo+IA0KPiBDYzogc3RhYmxlQGtlcm5lbC5vcmcNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFNo
YW55dSBaaGFvIDxzaGFueXUuemhhb0BpbnRlbC5jb20+DQo+IC0tLQ0KPiAgbmV0L3dpcmVsZXNz
L3dleHQtc21lLmMgfCAgICAxICsNCj4gIDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCsp
LCAwIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL25ldC93aXJlbGVzcy93ZXh0LXNt
ZS5jIGIvbmV0L3dpcmVsZXNzL3dleHQtc21lLmMNCj4gaW5kZXggZWVkZTM1Ni4uNWE2N2RkNSAx
MDA2NDQNCj4gLS0tIGEvbmV0L3dpcmVsZXNzL3dleHQtc21lLmMNCj4gKysrIGIvbmV0L3dpcmVs
ZXNzL3dleHQtc21lLmMNCj4gQEAgLTE5NCw2ICsxOTQsNyBAQCBpbnQgY2ZnODAyMTFfbWdkX3dl
eHRfc2l3ZXNzaWQoc3RydWN0IG5ldF9kZXZpY2UgKmRldiwNCj4gIAl3ZGV2LT53ZXh0LmNvbm5l
Y3Quc3NpZCA9IHdkZXYtPndleHQuc3NpZDsNCj4gIAltZW1jcHkod2Rldi0+d2V4dC5zc2lkLCBz
c2lkLCBsZW4pOw0KPiAgCXdkZXYtPndleHQuY29ubmVjdC5zc2lkX2xlbiA9IGxlbjsNCj4gKwl3
ZGV2LT53ZXh0LmNvbm5lY3QuYnNzaWQgPSBOVUxMOw0KDQpUaGlzIGlzIGluY29ycmVjdC4gSWYg
eW91IHdhbnQgdG8gY29ubmVjdCB0byBhbiBBUCB3aXRoIHRoZSBTU0lEICJmb28iDQphbmQgdGhl
IEJTU0lEICIwMDouLi46ZmYiIHlvdSBuZWVkIHRvIG1ha2UgdHdvIGNhbGxzLCBlLmcuDQoNCml3
Y29uZmlnIHdsYW4wIGVzc2lkICJmb28iDQppd2NvbmZpZyB3bGFuMCBhcCAiMDA6Li4uOmZmIg0K
DQpZb3VyIHBhdGNoIGRpc2FibGVzIHRoYXQgZnVuY3Rpb25hbGl0eS4NCg0Kam9oYW5uZXMNCg==

RE: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

On Mon, 2010-02-01 at 10:57 -0800, Zhao, Shanyu wrote:
> Actually I don't think my patch disables that functionality. If
> there're multiple AP with the same essid "foo" and one of them has MAC
> "00:...:ff", then:
> 
> iwconfig wlan0 essid "foo"
> This will make the station associate with the first AP with essid
> "foo".
> 
> iwconfig wlan0 ap "00:...:ff"
> This will disassociate from the previous AP, and then associate with
> the first AP with MAC "00:...:ff".
> 
> Am I missing anything here?

No, I missed something. The problem will only occur when the SSID is
hidden as well, because the connect code will not have the SSID and not
know what to scan for, or which SSID to choose (there are Cisco APs that
use the same BSSID for multiple hidden SSIDs).

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[John W. Linville]

On Mon, Feb 01, 2010 at 08:27:40PM +0100, Johannes Berg wrote:
> On Mon, 2010-02-01 at 10:57 -0800, Zhao, Shanyu wrote:
> > Actually I don't think my patch disables that functionality. If
> > there're multiple AP with the same essid "foo" and one of them has MAC
> > "00:...:ff", then:
> > 
> > iwconfig wlan0 essid "foo"
> > This will make the station associate with the first AP with essid
> > "foo".
> > 
> > iwconfig wlan0 ap "00:...:ff"
> > This will disassociate from the previous AP, and then associate with
> > the first AP with MAC "00:...:ff".
> > 
> > Am I missing anything here?
> 
> No, I missed something. The problem will only occur when the SSID is
> hidden as well, because the connect code will not have the SSID and not
> know what to scan for, or which SSID to choose (there are Cisco APs that
> use the same BSSID for multiple hidden SSIDs).

Well, in the confusion I deleted the original post.  Could you
(i.e. Shanyu Zhao) resend it to me?

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Mon, 2010-02-01 at 14:47 -0500, John W. Linville wrote:

> > > iwconfig wlan0 essid "foo"
> > > This will make the station associate with the first AP with essid
> > > "foo".
> > > 
> > > iwconfig wlan0 ap "00:...:ff"
> > > This will disassociate from the previous AP, and then associate with
> > > the first AP with MAC "00:...:ff".
> > > 
> > > Am I missing anything here?
> > 
> > No, I missed something. The problem will only occur when the SSID is
> > hidden as well, because the connect code will not have the SSID and not
> > know what to scan for, or which SSID to choose (there are Cisco APs that
> > use the same BSSID for multiple hidden SSIDs).
> 
> Well, in the confusion I deleted the original post.  Could you
> (i.e. Shanyu Zhao) resend it to me?

Sorry -- I wasn't clear. My mail missed something in describing the
problem, but that doesn't change the fact that the patch will break it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/1] cfg80211: wext: set bssid to NULL in SIOCIWESSID

[John W. Linville]

On Mon, Feb 01, 2010 at 10:25:04PM +0100, Johannes Berg wrote:
> On Mon, 2010-02-01 at 14:47 -0500, John W. Linville wrote:
> 
> > > > iwconfig wlan0 essid "foo"
> > > > This will make the station associate with the first AP with essid
> > > > "foo".
> > > > 
> > > > iwconfig wlan0 ap "00:...:ff"
> > > > This will disassociate from the previous AP, and then associate with
> > > > the first AP with MAC "00:...:ff".
> > > > 
> > > > Am I missing anything here?
> > > 
> > > No, I missed something. The problem will only occur when the SSID is
> > > hidden as well, because the connect code will not have the SSID and not
> > > know what to scan for, or which SSID to choose (there are Cisco APs that
> > > use the same BSSID for multiple hidden SSIDs).
> > 
> > Well, in the confusion I deleted the original post.  Could you
> > (i.e. Shanyu Zhao) resend it to me?
> 
> Sorry -- I wasn't clear. My mail missed something in describing the
> problem, but that doesn't change the fact that the patch will break it.

OK, thanks for clarifying! :-)

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.