Re: [PATCH] nl80211: allow adding new station to devices in mesh mode

Johannes Berg
2010-02-06T08:59:58Z

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Fri, 2010-02-05 at 09:47 -0800, Andrey Yurovsky wrote:
> Hi,
>
> On Fri, Feb 5, 2010 at 8:57 AM, Thadeu Lima de Souza Cascardo
> <cascardo@holoscopio.com> wrote:
> > After doing the "station new" command, I can do a "station dump" and get
> > my newly added station. So, I think this is ready for commit. And then,
> > we need to sort out both the WARNING and the panic for the Minstrel in
> > other patches too.
>
> Just to be clear, what are you trying to do here? Are you manually
> populating the peer links (stations) list? If so, why? Thanks,

Andrey, thanks for chiming in!

I do wonder though, the commit (155cc9e4b1d60161ee53) I referenced was
yours, and now you're asking the same question as I am -- "why even
allow adding stations?"

Should we just refuse it (again)? Clearly it would be safer than the
current code that's prone to crashes.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]