Re: [PATCH] nl80211: allow adding new station to devices in mesh mode

Thadeu Lima de Souza Cascardo
2010-02-05T18:00:38Z

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On Fri, Feb 05, 2010 at 09:47:44AM -0800, Andrey Yurovsky wrote:
> Hi,
>
> On Fri, Feb 5, 2010 at 8:57 AM, Thadeu Lima de Souza Cascardo
> <cascardo@holoscopio.com> wrote:
> > After doing the "station new" command, I can do a "station dump" and get
> > my newly added station. So, I think this is ready for commit. And then,
> > we need to sort out both the WARNING and the panic for the Minstrel in
> > other patches too.
>
> Just to be clear, what are you trying to do here? Are you manually
> populating the peer links (stations) list? If so, why? Thanks,
>
> -Andrey

I did not get automatic plinks for a peer. So, I decided to look at the
code and see when they got added to the sta list. It does when it
receives some management frames and also when it's added manually with
the NEW_STATION nl80211 command.

I want automatic plinks to work. But since I've started to play with it,
why not make the command just work. It's there. If adding plinks
manually to mesh nodes is not permitted, I may just send another patch,
disallowing it entirely and making it explicit in code, comment and git
log.

Did you have anything in mind for the use of this command to mesh mode?
One use case I can think of is to set the block action before the node
appears nearby (since station set will not work without the plink).

Regards,
Cascardo.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]