From: Bob Copeland <me@bobcopeland.com>
To: Benoit PAPILLAULT <benoit.papillault@free.fr>
Cc: jirislaby@gmail.com, mickflemm@gmail.com,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Fix TX/RX padding for all frames
Date: Mon, 15 Feb 2010 19:47:17 -0500 [thread overview]
Message-ID: <20100216004717.GA6844@hash.localnet> (raw)
In-Reply-To: <4B79C565.1050701@free.fr>
On Mon, Feb 15, 2010 at 11:06:29PM +0100, Benoit PAPILLAULT wrote:
>> Can you tell what the functional difference is between the old code and new
>> code? E.g. a padding that would be incorrectly computed from before?
>>
>>
> Correct. On some frames padding is incorrect. This patch is more for
> completeness since incorrect padding is only found by sending every kind
> of frames using a monitor interface. Moreover, since monitor interface
> are sometimes used to debug other issues, it's better not to have bugs
> here.
I meant, can you give an example of such a frame?
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2010-02-16 0:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 23:36 [PATCH] ath5k: Fix TX/RX padding for all frames Benoit Papillault
2010-02-15 20:15 ` Bob Copeland
2010-02-15 22:06 ` Benoit PAPILLAULT
2010-02-16 0:47 ` Bob Copeland [this message]
2010-02-16 20:39 ` Benoit PAPILLAULT
2010-02-17 6:15 ` Jouni Malinen
2010-02-17 7:01 ` Benoit PAPILLAULT
[not found] <--to jirislaby@gmail.com --to mickflemm@gmail.com \>
2010-02-27 12:58 ` Benoit Papillault
-- strict thread matches above, loose matches on Subject: below --
2010-02-27 20:58 [ath5k-devel] " Benoit PAPILLAULT
2010-02-27 22:05 ` Benoit Papillault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216004717.GA6844@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=benoit.papillault@free.fr \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).