From: "John W. Linville" <linville@tuxdriver.com>
To: Pavel Roskin <proski@gnu.org>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
Lennert Buytenhek <buytenh@marvell.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mwl8k: disable softirqs when accessing sta_notify_list
Date: Tue, 16 Feb 2010 19:33:39 -0500 [thread overview]
Message-ID: <20100217003338.GA12419@tuxdriver.com> (raw)
In-Reply-To: <1266355712.2659.16.camel@mj>
On Tue, Feb 16, 2010 at 04:28:32PM -0500, Pavel Roskin wrote:
> On Tue, 2010-02-16 at 12:03 -0800, Luis R. Rodriguez wrote:
> > On Sat, Feb 13, 2010 at 7:13 PM, Pavel Roskin <proski@gnu.org> wrote:
> > > Use spin_[un]lock_bh in mwl8k_sta_notify(). The sta_notify handler is
> > > required to be atomic, yet it can be called in process context, so make
> > > sure one call won't preempt another.
> >
> > Is this for stable as well?
>
> Since it wasn't tested on real hardware, I would say no, unless Lennert
> says otherwise.
That's how I saw it as well.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2010-02-17 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 3:13 [PATCH] mwl8k: disable softirqs when accessing sta_notify_list Pavel Roskin
2010-02-16 20:03 ` Luis R. Rodriguez
2010-02-16 21:28 ` Pavel Roskin
2010-02-17 0:33 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217003338.GA12419@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=buytenh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).