From: Jouni Malinen <j@w1.fi>
To: Benoit PAPILLAULT <benoit.papillault@free.fr>
Cc: Bob Copeland <me@bobcopeland.com>,
jirislaby@gmail.com, mickflemm@gmail.com,
ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: Fix TX/RX padding for all frames
Date: Wed, 17 Feb 2010 08:15:23 +0200 [thread overview]
Message-ID: <20100217061523.GA5147@jm.kir.nu> (raw)
In-Reply-To: <4B7B027D.70701@free.fr>
On Tue, Feb 16, 2010 at 09:39:25PM +0100, Benoit PAPILLAULT wrote:
> I don't have an ath5k based card at hand. I will try to grab one and
> will give an example of said frame. Basically, I followed the same
> strategy for ath9k already.
Are you saying that this patch has not actually been tested at all on
ath5k and it was just based on the changes you did for ath9k? If that is
the case, I would suggest running the tests before actually applying
this. We should really not depend on undocumented hardware behavior to
remain the same between different revisions. That's why I did not like
the changes in ath9k and would not exactly like extending that to even
more different chips taken into account that none of this is needed for
normal use of the card.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2010-02-17 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 23:36 [PATCH] ath5k: Fix TX/RX padding for all frames Benoit Papillault
2010-02-15 20:15 ` Bob Copeland
2010-02-15 22:06 ` Benoit PAPILLAULT
2010-02-16 0:47 ` Bob Copeland
2010-02-16 20:39 ` Benoit PAPILLAULT
2010-02-17 6:15 ` Jouni Malinen [this message]
2010-02-17 7:01 ` Benoit PAPILLAULT
[not found] <--to jirislaby@gmail.com --to mickflemm@gmail.com \>
2010-02-27 12:58 ` Benoit Papillault
-- strict thread matches above, loose matches on Subject: below --
2010-02-27 20:58 [ath5k-devel] " Benoit PAPILLAULT
2010-02-27 22:05 ` Benoit Papillault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217061523.GA5147@jm.kir.nu \
--to=j@w1.fi \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=benoit.papillault@free.fr \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).