Re: [PATCH 1/2] input: Add KEY_RFKILL

[Peter Hutterer <peter.hutterer@who-t.net>]

On Wed, Feb 17, 2010 at 06:49:35PM +0000, Bastien Nocera wrote:
> On Wed, 2010-02-17 at 18:45 +0000, Matthew Garrett wrote:
> > On Wed, Feb 17, 2010 at 07:43:56PM +0100, Christian Lamparter wrote:
> > 
> > > Wait wait... do you can get another KEY_?
> > > 
> > > The reason: Some new devices come with a WPS "Push Button".
> > > And there's no code for them yet.
> > 
> > What's a WPS button? There's no fundamental issue with getting new KEY_ 
> > codes defined, but bear in mind that anything greater than 255 won't be 
> > seen by X at present.
> 
> Won't be seen by most X applications. The server should definitely see
> it, so should applications that use XInput2-aware widget sets.
> 
> (Which obviously means not much at all right now).

Because XKB2 never happened we don't actually have any way of configuring
keysyms in the server for keys > 255 or getting this layout information to
the client. So XI2 applications that want to use higher keycodes are reliant
on the keycode itself which is strictly speaking random - at least the
protocol makes no guarantee that they remain fixed.

In practice that's not quite true and the keycodes are likely to remain
fixed but relying on that hurt us quite badly in the keyboard -> evdev
conversion.

Cheers,
  Peter