From: Greg KH <greg@kroah.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Frederic Leroy <fredo@starox.org>,
linux-wireless@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [RFC PATCH] staging: rtl8192su: remove dead code
Date: Thu, 18 Feb 2010 08:06:36 -0800 [thread overview]
Message-ID: <20100218160636.GK21785@kroah.com> (raw)
In-Reply-To: <4B7C1E82.4030005@lwfinger.net>
On Wed, Feb 17, 2010 at 10:51:14AM -0600, Larry Finger wrote:
> On 02/17/2010 02:19 AM, Frederic Leroy wrote:
> > Hello,
> >
> > This patch removes some dead code in rtl8192su driver in staging against linux-2.6-stable tree.
> > Should I split it into smaller chunk ?
> > As it is in staging, should I post it to linux-kernel@vger.kernel.org ?
>
> At 1400+ lines, the patch is a little large. I would recommend that you separate
> out the fixes for "ifdef RTL8190P" and "ifdef RTL8190U" into one patch, and the
> changes for "ifdef TO_DO_LIST" into a couple of patches. That should get the
> line count to below 500 in the individual patches.
I agree, that would be a better way to do this.
thanks,
greg k-h
prev parent reply other threads:[~2010-02-18 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 8:19 [RFC PATCH] staging: rtl8192su: remove dead code Frederic Leroy
2010-02-17 16:51 ` Larry Finger
2010-02-18 16:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218160636.GK21785@kroah.com \
--to=greg@kroah.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fredo@starox.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).