[PATCH 0/3 V2] staging: r8187se: Miscellaneous cleanups

[PATCH 0/3 V2] staging: r8187se: Miscellaneous cleanups

[Larry Finger]

This series of patches comprise further cleanups of the staging driver.

1. Remove dead routine from r8180_core.c.

2. Remove two private variables that have a fixed value.

3. Remove dead code from r8185b_init.c.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

Patch 1:

 r8180_core.c |   37 -------------------------------------
 1 file changed, 37 deletions(-)

Patch 2:

 r8180.h           |    4
 r8180_core.c      |   90 -------------
 r8180_dm.c        |   71 ++--------
 r8180_rtl8225z2.c |  238 +++++++++++++++-------------------
 r8185b_init.c     |  368 +++++++++++-------------------------------------------
 5 files changed, 197 insertions(+), 574 deletions(-)

Patch 3:

 r8185b_init.c |  633 ----------------------------------------------------------
 1 file changed, 2 insertions(+), 631 deletions(-)

Re: [PATCH 0/3 V2] staging: r8187se: Miscellaneous cleanups

[Greg KH]

On Mon, Feb 15, 2010 at 09:10:08AM -0600, Larry Finger wrote:
> This series of patches comprise further cleanups of the staging driver.
> 
> 1. Remove dead routine from r8180_core.c.
> 
> 2. Remove two private variables that have a fixed value.
> 
> 3. Remove dead code from r8185b_init.c.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Ick, I just applied your first versions of these patches.  What was the
difference here?  Care to look at the next linux-next tree and see if I
missed anything?

sorry about that.

greg k-h

Re: [PATCH 0/3 V2] staging: r8187se: Miscellaneous cleanups

[Larry Finger]

On 02/18/2010 10:03 AM, Greg KH wrote:
> On Mon, Feb 15, 2010 at 09:10:08AM -0600, Larry Finger wrote:
> 
> Ick, I just applied your first versions of these patches.  What was the
> difference here?  Care to look at the next linux-next tree and see if I
> missed anything?
> 
> sorry about that.

The only difference was that I fixed the line-wrap problem that you noted in
your previous Emails. I had found them and resubmitted. There were no content
changes in the patches and the tree appears to be OK.

Thanks for the heads-up and sorry for the trouble, Those damned long lines from
the Realtek driver are a pain.

FYI, the rewritten driver has received a beacon, and the first few parts have
been submitted to John Linville.

Larry

Re: [PATCH 0/3 V2] staging: r8187se: Miscellaneous cleanups

[Greg KH]

On Thu, Feb 18, 2010 at 11:01:36AM -0600, Larry Finger wrote:
> On 02/18/2010 10:03 AM, Greg KH wrote:
> > On Mon, Feb 15, 2010 at 09:10:08AM -0600, Larry Finger wrote:
> > 
> > Ick, I just applied your first versions of these patches.  What was the
> > difference here?  Care to look at the next linux-next tree and see if I
> > missed anything?
> > 
> > sorry about that.
> 
> The only difference was that I fixed the line-wrap problem that you noted in
> your previous Emails. I had found them and resubmitted. There were no content
> changes in the patches and the tree appears to be OK.
> 
> Thanks for the heads-up and sorry for the trouble, Those damned long lines from
> the Realtek driver are a pain.

Yes they are :)

> FYI, the rewritten driver has received a beacon, and the first few parts have
> been submitted to John Linville.

Wonderful, that's great to hear, hopefully we can delete this driver
soon.

thanks,

greg k-h