From: "John W. Linville" <linville@tuxdriver.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, stable@kernel.org,
Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH 3/3] iwlwifi: error checking for number of tfds in queue
Date: Fri, 19 Feb 2010 15:34:21 -0500 [thread overview]
Message-ID: <20100219203420.GO4950@tuxdriver.com> (raw)
In-Reply-To: <1266559301-19581-4-git-send-email-reinette.chatre@intel.com>
On Thu, Feb 18, 2010 at 10:01:41PM -0800, Reinette Chatre wrote:
> From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
>
> When receive reply_tx and ready to decrement the count for number of
> tfds in queue, do error checking to prevent error condition and
> tfds_in_queue become negative number.
>
> This fix starts to address
> http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2160 by preventing
> the bad situation from propagation when it does occur. This is needed while
> the cause of the decrement error is still traced.
>
> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> CC: stable@kernel.org
Since this apparently doesn't amount to a fix for the cited issue,
it doesn't seem worth pusing for 2.6.33 at the moment. Should I take
it in wireless-next-2.6? Or hold-out for a corrected version?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-02-19 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 6:01 [PATCH 0/3] fixes for 2.6.33 and stable Reinette Chatre
2010-02-19 6:01 ` [PATCH 1/3] iwlwifi: set HT flags after channel in rxon Reinette Chatre
2010-02-19 6:01 ` [PATCH 2/3] iwlwifi: sanity check before counting number of tfds can be free Reinette Chatre
2010-02-19 16:40 ` Stanislaw Gruszka
2010-02-19 17:57 ` Guy, Wey-Yi
2010-02-19 6:01 ` [PATCH 3/3] iwlwifi: error checking for number of tfds in queue Reinette Chatre
2010-02-19 20:34 ` John W. Linville [this message]
2010-02-19 20:59 ` reinette chatre
2010-02-19 23:24 ` [PATCH v2 " reinette chatre
2010-02-19 23:32 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219203420.GO4950@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=stable@kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).