From: Michael Buesch <mb@bu3sch.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
wireless <linux-wireless@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: Make b43 driver fall back gracefully to PIO mode after fatal DMA errors
Date: Sat, 27 Feb 2010 18:36:03 +0100 [thread overview]
Message-ID: <201002271836.04673.mb@bu3sch.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1002261231320.4513@localhost.localdomain>
On Friday 26 February 2010 21:33:08 Linus Torvalds wrote:
> So send me a patch. I'll try it.
Please check if the following patch makes any difference.
Also please show me the result of the printks.
Index: wireless-testing/drivers/ssb/driver_chipcommon_pmu.c
===================================================================
--- wireless-testing.orig/drivers/ssb/driver_chipcommon_pmu.c 2010-02-27 17:16:38.000000000 +0100
+++ wireless-testing/drivers/ssb/driver_chipcommon_pmu.c 2010-02-27 18:35:50.000000000 +0100
@@ -428,6 +428,9 @@ static void ssb_pmu_resources_init(struc
* min_msk = 0xCBB
* max_msk = 0x7FFFF
*/
+printk("PMU res init 4312/4322\n");
+min_msk = 0xFFFFFFFF;
+max_msk = 0xFFFFFFFF;
break;
case 0x4325:
/* Power OTP down later. */
@@ -442,6 +445,9 @@ static void ssb_pmu_resources_init(struc
updown_tab_size = ARRAY_SIZE(pmu_res_updown_tab_4325a0);
depend_tab = pmu_res_depend_tab_4325a0;
depend_tab_size = ARRAY_SIZE(pmu_res_depend_tab_4325a0);
+printk("PMU res init 4325\n");
+min_msk = 0xFFFFFFFF;
+max_msk = 0xFFFFFFFF;
break;
case 0x4328:
min_msk = (1 << SSB_PMURES_4328_EXT_SWITCHER_PWM) |
@@ -453,10 +459,16 @@ static void ssb_pmu_resources_init(struc
updown_tab_size = ARRAY_SIZE(pmu_res_updown_tab_4328a0);
depend_tab = pmu_res_depend_tab_4328a0;
depend_tab_size = ARRAY_SIZE(pmu_res_depend_tab_4328a0);
+printk("PMU res init 4328\n");
+min_msk = 0xFFFFFFFF;
+max_msk = 0xFFFFFFFF;
break;
case 0x5354:
/* The PLL may turn on, if it decides so. */
max_msk = 0xFFFFF;
+printk("PMU res init 5354\n");
+min_msk = 0xFFFFFFFF;
+max_msk = 0xFFFFFFFF;
break;
default:
ssb_printk(KERN_ERR PFX
@@ -538,6 +550,7 @@ void ssb_pmu_set_ldo_voltage(struct ssb_
switch (bus->chip_id) {
case 0x4328:
case 0x5354:
+printk("Set LDO 4328/5354\n");
switch (id) {
case LDO_VOLT1:
addr = 2;
@@ -565,6 +578,7 @@ void ssb_pmu_set_ldo_voltage(struct ssb_
}
break;
case 0x4312:
+printk("Set LDO 4312\n");
if (SSB_WARN_ON(id != LDO_PAREF))
return;
addr = 0;
@@ -584,6 +598,7 @@ void ssb_pmu_set_ldo_paref(struct ssb_ch
struct ssb_bus *bus = cc->dev->bus;
int ldo;
+printk("Set LDO paref\n");
switch (bus->chip_id) {
case 0x4312:
ldo = SSB_PMURES_4312_PA_REF_LDO;
--
Greetings, Michael.
next prev parent reply other threads:[~2010-02-27 18:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.1002261034140.4513@localhost.localdomain>
2010-02-26 19:09 ` Make b43 driver fall back gracefully to PIO mode after fatal DMA errors Larry Finger
2010-02-26 19:13 ` Linus Torvalds
2010-02-26 20:06 ` Linus Torvalds
2010-02-26 20:09 ` Gábor Stefanik
2010-02-26 20:50 ` Linus Torvalds
2010-02-26 21:01 ` Larry Finger
2010-02-26 21:45 ` Linus Torvalds
2010-02-26 21:50 ` Linus Torvalds
2010-02-26 22:08 ` Gábor Stefanik
2010-02-26 22:46 ` Linus Torvalds
2010-02-26 22:54 ` Gábor Stefanik
2010-02-27 15:04 ` Michael Buesch
2010-02-27 14:59 ` Michael Buesch
2010-02-27 18:31 ` Linus Torvalds
2010-02-27 18:51 ` Michael Buesch
2010-02-26 19:59 ` Michael Buesch
2010-02-26 20:07 ` Linus Torvalds
2010-02-26 20:20 ` Michael Buesch
2010-02-26 20:33 ` Linus Torvalds
2010-02-26 20:42 ` Linus Torvalds
2010-02-27 14:44 ` Michael Buesch
2010-02-27 14:49 ` Michael Buesch
2010-02-27 17:36 ` Michael Buesch [this message]
2010-02-27 20:12 ` Nathan Schulte
2010-02-27 21:08 ` Linus Torvalds
2010-02-27 21:43 ` Michael Buesch
2010-02-27 22:12 ` Linus Torvalds
2010-02-26 20:46 Nathan Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002271836.04673.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).