Re: Status of http://patchwork.kernel.org/patch/56785/

[Michael Buesch <mb@bu3sch.de>]

On Monday 01 March 2010 21:12:14 John W. Linville wrote:
> > An AP running 2.6.32 is unusable without those two patches.
> > However, it's rock stable as soon as those are applied.
> 
> commit a951ae2176b982574ffa197455db6c89359fd5eb
> Author: Bob Copeland <me@bobcopeland.com>
> Date:   Wed Jan 20 23:51:04 2010 -0500
> 
>     ath5k: fix setup for CAB queue
>     
>     The beacon sent gating doesn't seem to work with any combination
>     of flags.  Thus, buffered frames tend to stay buffered forever,
>     using up tx descriptors.
>     
>     Instead, use the DBA gating and hold transmission of the buffered
>     frames until 80% of the beacon interval has elapsed using the ready
>     time.  This fixes the following error in AP mode:
>     
>        ath5k phy0: no further txbuf available, dropping packet
>     
>     Add a comment to acknowledge that this isn't the best solution.
>     
>     Signed-off-by: Bob Copeland <me@bobcopeland.com>
>     Acked-by: Nick Kossifidis <mickflemm@gmail.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> commit 5d6ce628f986d1a3c523cbb0a5a52095c48cc332
> Author: Bob Copeland <me@bobcopeland.com>
> Date:   Wed Jan 20 23:51:03 2010 -0500
> 
>     ath5k: dont use external sleep clock in AP mode
>     
>     When using the external sleep clock in AP mode, the
>     TSF increments too quickly, causing beacon interval
>     to be much lower than it is supposed to be, resulting
>     in lots of beacon-not-ready interrupts.
>     
>     This fixes http://bugzilla.kernel.org/show_bug.cgi?id=14802.
>     
>     Signed-off-by: Bob Copeland <me@bobcopeland.com>
>     Acked-by: Nick Kossifidis <mickflemm@gmail.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 

Ok, so indeed, there was no CC to stable. I think these are critical patches
that should go into the stable tree.

-- 
Greetings, Michael.