Status of http://patchwork.kernel.org/patch/56785/

Status of http://patchwork.kernel.org/patch/56785/

[Drapko Nitzhonot]

Hi,
I've been using this patch for over one month and it resolves my
problem with ath5k in AP mode.
Before patch, I got "ath5k phy0: no further txbuf available, dropping
packet" and I had to restart hostapd
to make it to work again.

Does anybody knows if this patch will be finally apply to kernel?

Thanks.

Re: Status of http://patchwork.kernel.org/patch/56785/

[Michael Buesch]

On Saturday 27 February 2010 21:18:39 Drapko Nitzhonot wrote:
> Hi,
> I've been using this patch for over one month and it resolves my
> problem with ath5k in AP mode.
> Before patch, I got "ath5k phy0: no further txbuf available, dropping
> packet" and I had to restart hostapd
> to make it to work again.
> 
> Does anybody knows if this patch will be finally apply to kernel?

I think it is upstream through wireless-testing.
However, to say it once again, this is a -stable candidate.
(And while we are at it, that ath5k_dont_use_external_sleep_clock_in_AP_mode.patch
also is a stable candidate).

An AP running 2.6.32 is unusable without those two patches.
However, it's rock stable as soon as those are applied.

-- 
Greetings, Michael.

Re: Status of http://patchwork.kernel.org/patch/56785/

[John W. Linville]

On Sat, Feb 27, 2010 at 09:24:31PM +0100, Michael Buesch wrote:
> On Saturday 27 February 2010 21:18:39 Drapko Nitzhonot wrote:
> > Hi,
> > I've been using this patch for over one month and it resolves my
> > problem with ath5k in AP mode.
> > Before patch, I got "ath5k phy0: no further txbuf available, dropping
> > packet" and I had to restart hostapd
> > to make it to work again.
> > 
> > Does anybody knows if this patch will be finally apply to kernel?
> 
> I think it is upstream through wireless-testing.
> However, to say it once again, this is a -stable candidate.
> (And while we are at it, that ath5k_dont_use_external_sleep_clock_in_AP_mode.patch
> also is a stable candidate).
> 
> An AP running 2.6.32 is unusable without those two patches.
> However, it's rock stable as soon as those are applied.

commit a951ae2176b982574ffa197455db6c89359fd5eb
Author: Bob Copeland <me@bobcopeland.com>
Date:   Wed Jan 20 23:51:04 2010 -0500

    ath5k: fix setup for CAB queue
    
    The beacon sent gating doesn't seem to work with any combination
    of flags.  Thus, buffered frames tend to stay buffered forever,
    using up tx descriptors.
    
    Instead, use the DBA gating and hold transmission of the buffered
    frames until 80% of the beacon interval has elapsed using the ready
    time.  This fixes the following error in AP mode:
    
       ath5k phy0: no further txbuf available, dropping packet
    
    Add a comment to acknowledge that this isn't the best solution.
    
    Signed-off-by: Bob Copeland <me@bobcopeland.com>
    Acked-by: Nick Kossifidis <mickflemm@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

commit 5d6ce628f986d1a3c523cbb0a5a52095c48cc332
Author: Bob Copeland <me@bobcopeland.com>
Date:   Wed Jan 20 23:51:03 2010 -0500

    ath5k: dont use external sleep clock in AP mode
    
    When using the external sleep clock in AP mode, the
    TSF increments too quickly, causing beacon interval
    to be much lower than it is supposed to be, resulting
    in lots of beacon-not-ready interrupts.
    
    This fixes http://bugzilla.kernel.org/show_bug.cgi?id=14802.
    
    Signed-off-by: Bob Copeland <me@bobcopeland.com>
    Acked-by: Nick Kossifidis <mickflemm@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: Status of http://patchwork.kernel.org/patch/56785/

[Michael Buesch]

On Monday 01 March 2010 21:12:14 John W. Linville wrote:
> > An AP running 2.6.32 is unusable without those two patches.
> > However, it's rock stable as soon as those are applied.
> 
> commit a951ae2176b982574ffa197455db6c89359fd5eb
> Author: Bob Copeland <me@bobcopeland.com>
> Date:   Wed Jan 20 23:51:04 2010 -0500
> 
>     ath5k: fix setup for CAB queue
>     
>     The beacon sent gating doesn't seem to work with any combination
>     of flags.  Thus, buffered frames tend to stay buffered forever,
>     using up tx descriptors.
>     
>     Instead, use the DBA gating and hold transmission of the buffered
>     frames until 80% of the beacon interval has elapsed using the ready
>     time.  This fixes the following error in AP mode:
>     
>        ath5k phy0: no further txbuf available, dropping packet
>     
>     Add a comment to acknowledge that this isn't the best solution.
>     
>     Signed-off-by: Bob Copeland <me@bobcopeland.com>
>     Acked-by: Nick Kossifidis <mickflemm@gmail.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> commit 5d6ce628f986d1a3c523cbb0a5a52095c48cc332
> Author: Bob Copeland <me@bobcopeland.com>
> Date:   Wed Jan 20 23:51:03 2010 -0500
> 
>     ath5k: dont use external sleep clock in AP mode
>     
>     When using the external sleep clock in AP mode, the
>     TSF increments too quickly, causing beacon interval
>     to be much lower than it is supposed to be, resulting
>     in lots of beacon-not-ready interrupts.
>     
>     This fixes http://bugzilla.kernel.org/show_bug.cgi?id=14802.
>     
>     Signed-off-by: Bob Copeland <me@bobcopeland.com>
>     Acked-by: Nick Kossifidis <mickflemm@gmail.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 

Ok, so indeed, there was no CC to stable. I think these are critical patches
that should go into the stable tree.

-- 
Greetings, Michael.

Re: Status of http://patchwork.kernel.org/patch/56785/

[Bob Copeland]

On Mon, Mar 01, 2010 at 11:01:50PM +0100, Michael Buesch wrote:
> On Monday 01 March 2010 21:12:14 John W. Linville wrote:
> > commit a951ae2176b982574ffa197455db6c89359fd5eb
> > Author: Bob Copeland <me@bobcopeland.com>
> > Date:   Wed Jan 20 23:51:04 2010 -0500
> > 
> >     ath5k: fix setup for CAB queue
> > 
> > commit 5d6ce628f986d1a3c523cbb0a5a52095c48cc332
> > Author: Bob Copeland <me@bobcopeland.com>
> > Date:   Wed Jan 20 23:51:03 2010 -0500
> > 
> >     ath5k: dont use external sleep clock in AP mode
> 
> Ok, so indeed, there was no CC to stable. I think these are critical patches
> that should go into the stable tree.

Agreed - and stable is CCed on this thread.
-- 
Bob Copeland %% www.bobcopeland.com