From: Andrew Morton <akpm@linux-foundation.org>
To: 정재훈 <jh80.chung@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Subject: Re: [PATCH] rfkill bug fixed in rfkill_set_sw_state
Date: Tue, 2 Mar 2010 12:50:03 -0800 [thread overview]
Message-ID: <20100302125003.f7919c53.akpm@linux-foundation.org> (raw)
In-Reply-To: <000301cab69f$ec61ad00$c5250700$%chung@samsung.com>
Suitable cc's (from scripts/get_maintainer.pl) added.
On Fri, 26 Feb 2010 13:55:31 +0900
_________ <jh80.chung@samsung.com> wrote:
> Don___t work expected operation in __rfkill_set_sw_state.
> when rfkill initialized. Rfkill___s blocked & unblocked is operating on the
> contrary.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> ---
> net/rfkill/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index c224cb2..dcc2d38 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -488,7 +488,7 @@ static void __rfkill_set_sw_state(struct rfkill
> *rfkill, bool blocked)
> if (rfkill->state & RFKILL_BLOCK_SW_SETCALL)
> bit = RFKILL_BLOCK_SW_PREV;
>
> - if (blocked)
> + if (!blocked)
> rfkill->state |= bit;
> else
> rfkill->state &= ~bit;
Are you sure? What problems were you observing with the existing code?
Please fully describe your hardware and the driver's behaviour.
The current code _looks_ OK to me. If bool `blocked' is true, we set
the RFKILL_BLOCK_SW bit?
next parent reply other threads:[~2010-03-02 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000301cab69f$ec61ad00$c5250700$%chung@samsung.com>
2010-03-02 20:50 ` Andrew Morton [this message]
2010-03-03 0:47 ` [PATCH] rfkill bug fixed in rfkill_set_sw_state Jaehoon Chung
2010-03-03 9:37 ` Alan Jenkins
2010-03-03 10:14 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302125003.f7919c53.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=jh80.chung@samsung.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).