From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
tcpdump-workers@lists.tcpdump.org, proski@gnu.org
Subject: Re: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del]
Date: Wed, 03 Mar 2010 01:06:41 -0800 (PST) [thread overview]
Message-ID: <20100303.010641.04067796.davem@davemloft.net> (raw)
In-Reply-To: <20100303064001.GB2648@psychotron.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Wed, 3 Mar 2010 07:40:01 +0100
> Subject: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del]
>
> My previous patch 914c8ad2d18b62ad1420f518c0cab0b0b90ab308 incorrectly changed
> the length check in packet_mc_add to be more strict. The problem is that
> userspace is not filling this field (and it stays zeroed) in case of setting
> PACKET_MR_PROMISC or PACKET_MR_ALLMULTI. So move the strict check to the point
> in path where the addr_len must be set correctly.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied.
next prev parent reply other threads:[~2010-03-03 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 1:00 Current wireless-testing breaks libpcap: mr_alen should be set Pavel Roskin
2010-03-03 2:36 ` John W. Linville
2010-03-03 6:24 ` Jiri Pirko
2010-03-03 6:40 ` [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko
2010-03-03 6:57 ` Eric Dumazet
2010-03-03 9:05 ` Jiri Pirko
2010-03-03 9:06 ` David Miller
2010-03-03 9:06 ` David Miller [this message]
2010-03-03 15:31 ` [tcpdump-workers] Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller
2010-03-03 15:54 ` Jiri Pirko
2010-03-06 21:23 ` Guy Harris
2010-03-08 8:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303.010641.04067796.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
--cc=tcpdump-workers@lists.tcpdump.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).