From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org, jussi.kivilinna@mbnet.fi,
linux-wireless@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] wireless: convert to use netdev_for_each_mc_addr
Date: Thu, 04 Mar 2010 03:38:17 -0800 (PST) [thread overview]
Message-ID: <20100304.033817.217826832.davem@davemloft.net> (raw)
In-Reply-To: <20100304092014.GC2721@psychotron.lab.eng.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Thu, 4 Mar 2010 10:20:14 +0100
> Slapping myself twice on each cheek.
>
> Subject: [net-2.6 PATCH] rndis_wlan: correct multicast_list handling V3
>
> My previous patch (655ffee284dfcf9a24ac0343f3e5ee6db85b85c5) added locking in
> a bad way. Because rndis_set_oid can sleep, there is need to prepare multicast
> addresses into local buffer under netif_addr_lock first, then call
> rndis_set_oid outside. This caused reorganizing of the whole function.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> Reported-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Applied.
prev parent reply other threads:[~2010-03-04 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100303114506.19575pbsu8yz2kjk@hayate.sektori.org>
[not found] ` <20100303124249.GD2961@psychotron.lab.eng.brq.redhat.com>
[not found] ` <20100303184256.19122kg5hcqolfgg@hayate.sektori.org>
[not found] ` <20100303175229.GB2760@psychotron.redhat.com>
[not found] ` <20100303200510.17531s9x98zyvwm8@hayate.sektori.org>
2010-03-03 18:09 ` [net-next-2.6 PATCH] wireless: convert to use netdev_for_each_mc_addr Jiri Pirko
2010-03-04 8:41 ` David Miller
2010-03-04 8:52 ` David Miller
2010-03-04 9:20 ` Jiri Pirko
2010-03-04 11:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304.033817.217826832.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox