From: "John W. Linville" <linville@tuxdriver.com>
To: Senthil Balasubramanian <senthilkumar@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jiri Slaby <jirislaby@gmail.com>,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH] wireless: convert reg_regdb_search_lock to mutex
Date: Tue, 16 Mar 2010 20:24:16 -0400 [thread overview]
Message-ID: <20100317002416.GA2095@tuxdriver.com> (raw)
In-Reply-To: <20100316100337.GA1732@senthil-lnx.users.atheros.com>
On Tue, Mar 16, 2010 at 03:33:38PM +0530, Senthil Balasubramanian wrote:
> On Wed, Mar 17, 2010 at 01:19:00AM +0530, John W. Linville wrote:
> > Stanse discovered that kmalloc can be called with GFP_KERNEL while
> This commit log is confusing. It Should be "Stanse discovered kmalloc
> was called with GFP_KERNEL". Obviously kmalloc with GFP_KERNEL shouldn't
> be used while holding a spinlock.
> > holding this spinlock. It can be a mutex instead.
Not half so confusing as your criticism... :-)
Are you objecting to "can be" instead of "was"?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-03-17 0:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 13:26 regd: sleeping in atomic Jiri Slaby
2010-03-16 16:18 ` Luis R. Rodriguez
2010-03-16 18:42 ` Jiri Slaby
2010-03-16 20:36 ` Luis R. Rodriguez
2010-03-16 19:49 ` [PATCH] wireless: convert reg_regdb_search_lock to mutex John W. Linville
2010-03-16 10:03 ` Senthil Balasubramanian
2010-03-17 0:24 ` John W. Linville [this message]
2010-03-16 12:24 ` Senthil Balasubramanian
2010-03-17 2:56 ` John W. Linville
2010-03-17 3:24 ` Johannes Berg
2010-03-17 1:26 ` Senthil Balasubramanian
2010-03-17 12:55 ` John W. Linville
2010-03-17 13:01 ` John W. Linville
2010-03-17 19:33 ` [PATCH v2] " John W. Linville
2010-03-18 20:47 ` [PATCH v3] " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317002416.GA2095@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=senthilkumar@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).