* Re: [ath9k-devel] [RFC] ath9k: 4ms frame length table update [not found] <1aee2dca1003172337g5d66a03ex20ebab74707a6c56@mail.gmail.com> @ 2010-03-18 16:00 ` Luis R. Rodriguez 2010-03-18 16:53 ` Vasanthakumar Thiagarajan 0 siblings, 1 reply; 2+ messages in thread From: Luis R. Rodriguez @ 2010-03-18 16:00 UTC (permalink / raw) To: selvam; +Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, Vipin M On Wed, Mar 17, 2010 at 11:37:29PM -0700, selvam wrote: > Hi, > > The 4 ms frame length table is updated to support up to MCS 31. > > These values are calculated based on the equation 9.1 from the IEEE 802.11n standard. > These values are rounded off to multiple of 4 bytes. If the final value is greater than 65535 then it is changed to 65532, since the maximum A-MPDU length is 65535 bytes. Thanks for this patch, but can you elaborate on what your patch does other than the above. For example, you may want to mention that although the current ath9k driver does not support up to MCS31 your patch would enable such support for future chipsets which could be supported. You also forgot to Signed-off-by it, and provide a clearer commit log entry. Check git log for examples on wireless-testing, also read: http://wireless.kernel.org/en/developers/Documentation/SubmittingPatches http://wireless.kernel.org/en/developers/Documentation Luis ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ath9k-devel] [RFC] ath9k: 4ms frame length table update 2010-03-18 16:00 ` [ath9k-devel] [RFC] ath9k: 4ms frame length table update Luis R. Rodriguez @ 2010-03-18 16:53 ` Vasanthakumar Thiagarajan 0 siblings, 0 replies; 2+ messages in thread From: Vasanthakumar Thiagarajan @ 2010-03-18 16:53 UTC (permalink / raw) To: Luis R. Rodriguez Cc: selvam, ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, Vipin M On Thu, Mar 18, 2010 at 09:30:34PM +0530, Luis R. Rodriguez wrote: > On Wed, Mar 17, 2010 at 11:37:29PM -0700, selvam wrote: > > Hi, > > > > The 4 ms frame length table is updated to support up to MCS 31. > > > > These values are calculated based on the equation 9.1 from the IEEE 802.11n standard. > > These values are rounded off to multiple of 4 bytes. If the final value is greater than 65535 then it is changed to 65532, since the maximum A-MPDU length is 65535 bytes. > > Thanks for this patch, but can you elaborate on what your patch does other > than the above. For example, you may want to mention that although the current > ath9k driver does not support up to MCS31 your patch would enable such support > for future chipsets which could be supported. You also forgot to Signed-off-by > it, and provide a clearer commit log entry. Check git log for examples on > wireless-testing, also read: > Also, rate control component of ath9k is not generic, it is specific to ath9k. So this sort of patches make sense only when ath9k supports hw with three chains, currently ath9k does not have support for those hw. Vasanth ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-18 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1aee2dca1003172337g5d66a03ex20ebab74707a6c56@mail.gmail.com>
2010-03-18 16:00 ` [ath9k-devel] [RFC] ath9k: 4ms frame length table update Luis R. Rodriguez
2010-03-18 16:53 ` Vasanthakumar Thiagarajan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).