* [PATCH 0/2] Two small fixes for rt2x00.
@ 2010-03-24 20:42 Gertjan van Wingerde
2010-03-24 20:42 ` [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800 Gertjan van Wingerde
2010-03-24 20:42 ` [PATCH 2/2] rt2x00: Disable powersaving by default in rt2500usb Gertjan van Wingerde
0 siblings, 2 replies; 6+ messages in thread
From: Gertjan van Wingerde @ 2010-03-24 20:42 UTC (permalink / raw)
To: John W. Linville
Cc: Ivo van Doorn, linux-wireless, users, Gertjan van Wingerde
John,
These are two small fixes for rt2x00 that accumulated in my tree.
Both are generated against wireless-2.6, but should apply to
wireless-next-2.6, so apply to the tree you feel most appropriate
for this.
The patches can also be pulled from:
git://git.gwingerde.nl/rt2x00-2.6
Gertjan van Wingerde (2):
rt2x00: Fix typo in RF register programming of rt2800.
rt2x00: Disable powersaving by default in rt2500usb.
drivers/net/wireless/rt2x00/rt2500usb.c | 5 +++++
drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800.
2010-03-24 20:42 [PATCH 0/2] Two small fixes for rt2x00 Gertjan van Wingerde
@ 2010-03-24 20:42 ` Gertjan van Wingerde
2010-03-24 22:13 ` Ivo van Doorn
2010-04-06 14:55 ` Helmut Schaa
2010-03-24 20:42 ` [PATCH 2/2] rt2x00: Disable powersaving by default in rt2500usb Gertjan van Wingerde
1 sibling, 2 replies; 6+ messages in thread
From: Gertjan van Wingerde @ 2010-03-24 20:42 UTC (permalink / raw)
To: John W. Linville
Cc: Ivo van Doorn, linux-wireless, users, Gertjan van Wingerde
Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
---
drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 18d4d8e..326fce7 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -812,9 +812,9 @@ static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev,
rt2800_rfcsr_write(rt2x00dev, 24,
rt2x00dev->calibration[conf_is_ht40(conf)]);
- rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
+ rt2800_rfcsr_read(rt2x00dev, 7, &rfcsr);
rt2x00_set_field8(&rfcsr, RFCSR7_RF_TUNING, 1);
- rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);
+ rt2800_rfcsr_write(rt2x00dev, 7, rfcsr);
}
static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
--
1.7.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800.
2010-03-24 20:42 ` [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800 Gertjan van Wingerde
@ 2010-03-24 22:13 ` Ivo van Doorn
2010-04-06 14:55 ` Helmut Schaa
1 sibling, 0 replies; 6+ messages in thread
From: Ivo van Doorn @ 2010-03-24 22:13 UTC (permalink / raw)
To: Gertjan van Wingerde; +Cc: John W. Linville, linux-wireless, users
On Wednesday 24 March 2010, Gertjan van Wingerde wrote:
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 18d4d8e..326fce7 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -812,9 +812,9 @@ static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev,
> rt2800_rfcsr_write(rt2x00dev, 24,
> rt2x00dev->calibration[conf_is_ht40(conf)]);
>
> - rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
> + rt2800_rfcsr_read(rt2x00dev, 7, &rfcsr);
> rt2x00_set_field8(&rfcsr, RFCSR7_RF_TUNING, 1);
> - rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);
> + rt2800_rfcsr_write(rt2x00dev, 7, rfcsr);
> }
>
> static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800.
2010-03-24 20:42 ` [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800 Gertjan van Wingerde
2010-03-24 22:13 ` Ivo van Doorn
@ 2010-04-06 14:55 ` Helmut Schaa
1 sibling, 0 replies; 6+ messages in thread
From: Helmut Schaa @ 2010-04-06 14:55 UTC (permalink / raw)
To: Gertjan van Wingerde
Cc: John W. Linville, Ivo van Doorn, linux-wireless, users
Thanks Gertjan. I just stumbled over the same issue. This allows
scanning on all channel on the SoC platform.
Helmut
Am Mittwoch 24 März 2010 schrieb Gertjan van Wingerde:
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 18d4d8e..326fce7 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -812,9 +812,9 @@ static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev,
> rt2800_rfcsr_write(rt2x00dev, 24,
> rt2x00dev->calibration[conf_is_ht40(conf)]);
>
> - rt2800_rfcsr_read(rt2x00dev, 23, &rfcsr);
> + rt2800_rfcsr_read(rt2x00dev, 7, &rfcsr);
> rt2x00_set_field8(&rfcsr, RFCSR7_RF_TUNING, 1);
> - rt2800_rfcsr_write(rt2x00dev, 23, rfcsr);
> + rt2800_rfcsr_write(rt2x00dev, 7, rfcsr);
> }
>
> static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] rt2x00: Disable powersaving by default in rt2500usb.
2010-03-24 20:42 [PATCH 0/2] Two small fixes for rt2x00 Gertjan van Wingerde
2010-03-24 20:42 ` [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800 Gertjan van Wingerde
@ 2010-03-24 20:42 ` Gertjan van Wingerde
2010-03-24 22:13 ` Ivo van Doorn
1 sibling, 1 reply; 6+ messages in thread
From: Gertjan van Wingerde @ 2010-03-24 20:42 UTC (permalink / raw)
To: John W. Linville
Cc: Ivo van Doorn, linux-wireless, users, Gertjan van Wingerde
Recent bug reports have shown that rt2500usb also suffers from the
powersave problems that the PCI rt2x00 drivers suffer from.
So disable powersaving by default for rt2500usb as well.
Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
---
drivers/net/wireless/rt2x00/rt2500usb.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
index ee34c13..dbaa781 100644
--- a/drivers/net/wireless/rt2x00/rt2500usb.c
+++ b/drivers/net/wireless/rt2x00/rt2500usb.c
@@ -1643,6 +1643,11 @@ static int rt2500usb_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
unsigned int i;
/*
+ * Disable powersaving as default.
+ */
+ rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
+
+ /*
* Initialize all hw fields.
*/
rt2x00dev->hw->flags =
--
1.7.0.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] rt2x00: Disable powersaving by default in rt2500usb.
2010-03-24 20:42 ` [PATCH 2/2] rt2x00: Disable powersaving by default in rt2500usb Gertjan van Wingerde
@ 2010-03-24 22:13 ` Ivo van Doorn
0 siblings, 0 replies; 6+ messages in thread
From: Ivo van Doorn @ 2010-03-24 22:13 UTC (permalink / raw)
To: Gertjan van Wingerde; +Cc: John W. Linville, linux-wireless, users
On Wednesday 24 March 2010, Gertjan van Wingerde wrote:
> Recent bug reports have shown that rt2500usb also suffers from the
> powersave problems that the PCI rt2x00 drivers suffer from.
> So disable powersaving by default for rt2500usb as well.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2500usb.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> index ee34c13..dbaa781 100644
> --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> @@ -1643,6 +1643,11 @@ static int rt2500usb_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
> unsigned int i;
>
> /*
> + * Disable powersaving as default.
> + */
> + rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> +
> + /*
> * Initialize all hw fields.
> */
> rt2x00dev->hw->flags =
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-06 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-24 20:42 [PATCH 0/2] Two small fixes for rt2x00 Gertjan van Wingerde
2010-03-24 20:42 ` [PATCH 1/2] rt2x00: Fix typo in RF register programming of rt2800 Gertjan van Wingerde
2010-03-24 22:13 ` Ivo van Doorn
2010-04-06 14:55 ` Helmut Schaa
2010-03-24 20:42 ` [PATCH 2/2] rt2x00: Disable powersaving by default in rt2500usb Gertjan van Wingerde
2010-03-24 22:13 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).