From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Michael Sprecher <sprecher.m@gmail.com>,
jmalinen@atheros.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH] wireless: ath9k: Fix most coding style issues in ath9k This patch fixed up almost all coding style issues in the ath9k driver found by the ceckpatch.pl tool. Signed-off-by: Michael Sprecher <sprecher.m@gmail.com>
Date: Thu, 8 Apr 2010 14:41:07 -0400 [thread overview]
Message-ID: <20100408184106.GA2999@tuxdriver.com> (raw)
In-Reply-To: <43e72e891003091133h31bfb1c5sceb4d3c9258792e6@mail.gmail.com>
On Tue, Mar 09, 2010 at 11:33:44AM -0800, Luis R. Rodriguez wrote:
> On Tue, Mar 9, 2010 at 11:05 AM, Michael Sprecher <sprecher.m@gmail.com> wrote:
> > ---
> > drivers/net/wireless/ath/ath9k/ani.c | 5 ++-
> > drivers/net/wireless/ath/ath9k/ath9k.h | 28 ++++++++--------
> > drivers/net/wireless/ath/ath9k/beacon.c | 6 ++--
> > drivers/net/wireless/ath/ath9k/btcoex.h | 6 ++--
> > drivers/net/wireless/ath/ath9k/calib.c | 15 ++++-----
> > drivers/net/wireless/ath/ath9k/calib.h | 4 +-
> > drivers/net/wireless/ath/ath9k/common.c | 20 +++++------
> > drivers/net/wireless/ath/ath9k/common.h | 10 +++---
> > drivers/net/wireless/ath/ath9k/debug.c | 12 +++---
> > drivers/net/wireless/ath/ath9k/eeprom.h | 4 +-
> > drivers/net/wireless/ath/ath9k/eeprom_4k.c | 16 +++++-----
> > drivers/net/wireless/ath/ath9k/eeprom_9287.c | 14 +++++---
> > drivers/net/wireless/ath/ath9k/eeprom_def.c | 31 +++++++++---------
> > drivers/net/wireless/ath/ath9k/gpio.c | 2 +-
> > drivers/net/wireless/ath/ath9k/hw.c | 44 +++++++++++--------------
> > drivers/net/wireless/ath/ath9k/hw.h | 22 ++++++------
> > drivers/net/wireless/ath/ath9k/init.c | 6 ++--
> > drivers/net/wireless/ath/ath9k/mac.h | 2 +-
> > drivers/net/wireless/ath/ath9k/main.c | 26 +++++++-------
> > drivers/net/wireless/ath/ath9k/phy.c | 12 +++----
> > drivers/net/wireless/ath/ath9k/phy.h | 4 +-
> > drivers/net/wireless/ath/ath9k/rc.c | 13 +++----
> > drivers/net/wireless/ath/ath9k/rc.h | 4 +-
> > drivers/net/wireless/ath/ath9k/recv.c | 5 +--
> > drivers/net/wireless/ath/ath9k/reg.h | 22 ++++++------
> > drivers/net/wireless/ath/ath9k/virtual.c | 3 +-
> > drivers/net/wireless/ath/ath9k/xmit.c | 11 +++---
> > 27 files changed, 167 insertions(+), 180 deletions(-)
>
> Thanks a lot! Unfortunately right now we have two large patch bombs
> pending integration which would likely conflict with your patch. One
> set which I hope we can get into 2.6.34-rc2, the ath9k_htc driver.
> Then after that I have an already accumulated set of patches (count is
> at 10 right now) for AR93xx work. The ar93xx work is not intended for
> 2.6.34 though so I could rebase my work on top of yours but lets first
> see ath9k_htc get merged first and decide then.
>
> So NACK for now.
I think it is safe to rebase this now, if you are still interested... :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-04-08 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 19:05 [PATCH] wireless: ath9k: Fix most coding style issues in ath9k This patch fixed up almost all coding style issues in the ath9k driver found by the ceckpatch.pl tool. Signed-off-by: Michael Sprecher <sprecher.m@gmail.com> Michael Sprecher
2010-03-09 19:33 ` Luis R. Rodriguez
2010-04-08 18:41 ` John W. Linville [this message]
2010-04-08 19:12 ` Luis R. Rodriguez
[not found] ` <h2xf42143521004271314rb3a000arba8f9df5846e71ab@mail.gmail.com>
[not found] ` <j2of42143521004271315ice41b0edtabf0ed4914342d41@mail.gmail.com>
[not found] ` <s2yf42143521004271321qe6522fdaia42f335575d4026@mail.gmail.com>
2010-04-27 21:05 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408184106.GA2999@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=jmalinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=sprecher.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).