From: "John W. Linville" <linville@tuxdriver.com>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: avoid warning by using result of iwl_send_cmd_pdu in iwl_sta_init_lq
Date: Thu, 8 Apr 2010 16:41:23 -0400 [thread overview]
Message-ID: <20100408204123.GF2999@tuxdriver.com> (raw)
In-Reply-To: <1270758273.14052.217.camel@rchatre-DESK>
On Thu, Apr 08, 2010 at 01:24:33PM -0700, reinette chatre wrote:
> Hi John,
>
> On Thu, 2010-04-08 at 12:48 -0700, John W. Linville wrote:
> > CC [M] drivers/net/wireless/iwlwifi/iwl-sta.o
> > drivers/net/wireless/iwlwifi/iwl-sta.c: In function ‘iwl_sta_init_lq’:
> > drivers/net/wireless/iwlwifi/iwl-sta.c:461: warning: ignoring return value of ‘iwl_send_cmd_pdu’, declared with attribute warn_unused_result
> >
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > ---
> > drivers/net/wireless/iwlwifi/iwl-sta.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c b/drivers/net/wireless/iwlwifi/iwl-sta.c
> > index e34ac03..91aaf11 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-sta.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
> > @@ -458,8 +458,9 @@ static void iwl_sta_init_lq(struct iwl_priv *priv, const u8 *addr, bool is_ap)
> > /* Update the rate scaling for control frame Tx to AP */
> > link_cmd.sta_id = is_ap ? IWL_AP_ID : priv->hw_params.bcast_sta_id;
> >
> > - iwl_send_cmd_pdu(priv, REPLY_TX_LINK_QUALITY_CMD,
> > - sizeof(link_cmd), &link_cmd);
> > + if (!iwl_send_cmd_pdu(priv, REPLY_TX_LINK_QUALITY_CMD,
> > + sizeof(link_cmd), &link_cmd))
> > + IWL_WARN(priv, "Tx link quality reply failed\n");
> > }
> >
> > /*
>
> I made a mistake here somewhere since this is fixed in iwlwifi-2.6 but
> did not propagate to wireless-next-2.6.
>
> Wouldn't the above print the warning on success though?
Ha, yes...
> In iwlwifi-2.6 the code looks like (whitespace broken copy&pasted) ...
> it would be nice to have the return code available in error message:
>
> ret = iwl_send_cmd_pdu(priv, REPLY_TX_LINK_QUALITY_CMD,
> sizeof(link_cmd), &link_cmd);
> if (ret)
> IWL_ERR(priv, "REPLY_TX_LINK_QUALITY_CMD failed (%d)\n", ret);
>
> If you want I can just fix my merging mistake.
Works for me!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2010-04-08 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 19:48 [PATCH] iwlwifi: avoid warning by using result of iwl_send_cmd_pdu in iwl_sta_init_lq John W. Linville
2010-04-08 20:24 ` reinette chatre
2010-04-08 20:41 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408204123.GF2999@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).