Re: [PATCH 012/102] ath9k_hw: add a private callback for PLL control computation

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Tue, Apr 13, 2010 at 04:38:01PM -0700, John W. Linville wrote:
> On Tue, Apr 13, 2010 at 02:42:13PM -0700, Luis R. Rodriguez wrote:
> > On Tue, Apr 13, 2010 at 1:15 PM, Felix Fietkau <nbd@openwrt.org> wrote:
> > > On 2010-04-13 9:54 PM, John W. Linville wrote:
> > >> On Thu, Apr 08, 2010 at 03:26:08PM -0400, Luis R. Rodriguez wrote:
> > >>> The PLL control computation used to program the AR_RTC_PLL_CONTROL
> > >>> register varies between our harware so just add a private callback for it.
> > >>> AR9003 will use its own callback.
> > >>>
> > >>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > >>> ---
> > >>>  drivers/net/wireless/ath/ath9k/ar5008_phy.c |   55 +++++++++++++++++++++++
> > >>>  drivers/net/wireless/ath/ath9k/ar9002_phy.c |   31 +++++++++++++
> > >>>  drivers/net/wireless/ath/ath9k/hw.c         |   64 +++------------------------
> > >>>  drivers/net/wireless/ath/ath9k/hw.h         |    4 ++
> > >>>  4 files changed, 97 insertions(+), 57 deletions(-)
> > >>>
> > >>> diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
> > >>> index 4459d63..31ecea8 100644
> > >>> --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c
> > >>> +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
> > >>> @@ -961,6 +961,54 @@ static void ar5008_set_diversity(struct ath_hw *ah, bool value)
> > >>
> > >> <snip>
> > >>
> > >> drivers/net/wireless/ath/ath9k/ar5008_phy.c doesn't seem to exist...?
> > > Luis' git version creates patches that mark renames in metadata, so they
> > > probably won't apply when using 'patch', only with 'git apply'...
> > > Patch 009 renames phy.c to ar5008_phy.c
> > 
> > Right, so this is part of the -M on git format-patch, we do this to
> > keep the patch diff stat to 0 so that its clear no changes were
> > actually made to the file.
> 
> FWIW, I was using "git apply" with your all-<whatever>.patch mbox file.
> Maybe you generated that differently.
> 
> Anyway, I'm happy to wait for the repost to try again. :-)

Interesting -- hm, yeah this is odd. Lets see on the respin.

  Luis