Re: Survey mode volunteers

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Wed, Apr 14, 2010 at 12:11:11AM -0700, Holger Schurig wrote:
> I've some preliminary patch for ath5k.
> 
> ---
> Subject: [ath5k] add noise reporting to survey
> 
> Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
> 
> ---
>  drivers/net/wireless/ath/ath5k/base.c |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> --- compat-wireless-2010-03-15.orig/drivers/net/wireless/ath/ath5k/base.c
> +++ compat-wireless-2010-03-15/drivers/net/wireless/ath/ath5k/base.c
> @@ -273,6 +273,8 @@ static int ath5k_set_key(struct ieee8021
>  		struct ieee80211_key_conf *key);
>  static int ath5k_get_stats(struct ieee80211_hw *hw,
>  		struct ieee80211_low_level_stats *stats);
> +static int ath5k_get_survey(struct ieee80211_hw *hw,
> +		int idx, struct survey_info *survey);
>  static u64 ath5k_get_tsf(struct ieee80211_hw *hw);
>  static void ath5k_set_tsf(struct ieee80211_hw *hw, u64 tsf);
>  static void ath5k_reset_tsf(struct ieee80211_hw *hw);
> @@ -298,6 +300,7 @@ static const struct ieee80211_ops ath5k_
>  	.configure_filter = ath5k_configure_filter,
>  	.set_key 	= ath5k_set_key,
>  	.get_stats 	= ath5k_get_stats,
> +	.get_survey	= ath5k_get_survey,
>  	.conf_tx 	= NULL,
>  	.get_tsf 	= ath5k_get_tsf,
>  	.set_tsf 	= ath5k_set_tsf,
> @@ -3250,6 +3253,22 @@ ath5k_get_stats(struct ieee80211_hw *hw,
>  
>  	return 0;
>  }
> +
> +static int ath5k_get_survey(struct ieee80211_hw *hw, int idx,
> +		struct survey_info *survey)
> +{
> +	struct ath5k_softc *sc = hw->priv;
> +	struct ieee80211_conf *conf = &hw->conf;
> +
> +	 if (idx != 0)
> +		return -ENOENT;
> +
> +	survey->channel = conf->channel;
> +	survey->filled = SURVEY_INFO_NOISE_DBM;
> +	survey->noise = sc->ah->ah_noise_floor;
> +
> +	return 0;
> +}

Nice, it should be very similar for ath9k BTW, one enhancement which we've
been meanint to address but haven't had the time yet is to split noise floor
per channel. This can be seen how its done on the legacy HAL with the code
sprinkled with the ATH_NF_PER_CHAN ifdef.

  Luis