From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Pavel Roskin <proski@gnu.org>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath9k_hw: make two initvals consto for the AR9001 family
Date: Wed, 21 Apr 2010 15:38:38 -0700 [thread overview]
Message-ID: <20100421223838.GA2266@tux> (raw)
In-Reply-To: <1271886897.6212.9.camel@mj>
On Wed, Apr 21, 2010 at 02:54:57PM -0700, Pavel Roskin wrote:
> On Tue, 2010-04-20 at 18:28 -0400, Luis R. Rodriguez wrote:
> > This makes ar5416Addac_9160 and ar5416Addac_9160 const
> > I guess we skipped them long ago.
>
> It's a step in the right direction, but it makes the code more
> misleading. Those arrays are not constant.
>
> Please see ath9k_hw_def_set_addac() and ath9k_hw_4k_set_addac(). They
> both modify ah->iniAddac for AR9160.
>
> The compiler doesn't warn about it because the definition of
> INIT_INI_ARRAY uses a cast that removes the const modifier.
>
> It's not an objection against the patch, it's just a reminder that we
> have a real problem with the code that is likely to affect parallel
> operation of more than one AR9160 device in the system, especially if
> they are working on different channels.
Yeah good point, well not sure how to resolve that, other than leaving
it as is for now. Let me know if you come up with something.
Luis
next prev parent reply other threads:[~2010-04-21 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 22:28 [PATCH 0/2] ath9k_hw: few initval cosmetic changes Luis R. Rodriguez
2010-04-20 22:28 ` [PATCH 1/2] ath9k_hw: make two initvals consto for the AR9001 family Luis R. Rodriguez
2010-04-21 21:54 ` Pavel Roskin
2010-04-21 22:38 ` Luis R. Rodriguez [this message]
2010-04-20 22:28 ` [PATCH 2/2] ath9k_hw: make all AR9002 initvals use u32 Luis R. Rodriguez
2010-04-20 23:34 ` Gábor Stefanik
2010-04-20 23:43 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421223838.GA2266@tux \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).