Re: [PATCH] Added configurable debug messages to libertastf

[Andrew Morton <akpm@linux-foundation.org>]

On Sun, 25 Apr 2010 14:40:46 -0700
Steve deRosier <steve@cozybit.com> wrote:

> Add the same type of configurable debug messages to libertas_tf as
> already exist in the libertas driver.  This has facilitated creation of a interface
> specification and will facilitate future development of this driver.
> 
> ...
>
> --- /dev/null
> +++ b/drivers/net/wireless/libertas_tf/deb_defs.h
> @@ -0,0 +1,106 @@
> +/**
> +  * This header file contains global constant/enum definitions,
> +  * global variable declaration.
> +  */
> +#ifndef _LBS_DEB_DEFS_H_
> +#define _LBS_DEB_EFS_H_
> +
> +#ifndef DRV_NAME
> +#define DRV_NAME "libertas_tf"
> +#endif
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +

I dunno what this pr_fmt() definition is doing here, but it has
unpleasant effects with a x86_64 allmodconfig build:

In file included from drivers/net/wireless/libertas_tf/main.c:12:
drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
In file included from /usr/src/devel/arch/x86/include/asm/percpu.h:44,
	from /usr/src/devel/arch/x86/include/asm/current.h:5,
	from /usr/src/devel/arch/x86/include/asm/processor.h:15,
	from /usr/src/devel/arch/x86/include/asm/thread_info.h:22,
	from include/linux/thread_info.h:56,
	from include/linux/preempt.h:9,
	from include/linux/spinlock.h:50,
	from include/linux/mmzone.h:7,
	from include/linux/gfp.h:4,
	from include/linux/slab.h:12,
	from drivers/net/wireless/libertas_tf/main.c:10:
include/linux/kernel.h:376:1: warning: this is the location of the previous definition

so I cheerily deleted it.