linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Lippers-Hollmann" <s.L-H@gmx.de>
To: "David H. Lynch Jr." <dhlii@dlasys.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: ar9170-fw
Date: Sat, 1 May 2010 03:23:49 +0200	[thread overview]
Message-ID: <201005010323.53295.s.L-H@gmx.de> (raw)
In-Reply-To: <4BDB72AA.7000203@dlasys.net>

Hi

On Saturday 01 May 2010, David H. Lynch Jr. wrote:
>      I tried to build the toolchain from an uptodate pull of the git 
> repository,
> 
>      I am getting a sequence of errors when the build reach libssp.
> 
>      My guess would be that libssp is not needed for the ar9170 firmware.
> 
>      Is this correct and I would appreciate an easy suguestion to 
> disable it if so.
> 
> make[3]: Entering directory `/usr/src/ar9170-fw/toolchain/build/gcc/sh-elf/libssp'
[...]
> -I/usr/src/ar9170-fw/toolchain/src/gcc-4.3.3/libssp -I. -Wall -O2 -g -g -O2 -MT
> ssp.lo -MD -MP -MF .deps/ssp.Tpo -c
> /usr/src/ar9170-fw/toolchain/src/gcc-4.3.3/libssp/ssp.c -o ssp.o
> /usr/src/ar9170-fw/toolchain/src/gcc-4.3.3/libssp/ssp.c: In function
> '__guard_setup':
> /usr/src/ar9170-fw/toolchain/src/gcc-4.3.3/libssp/ssp.c:70: warning: implicit
> declaration of function 'open'
> /usr/src/ar9170-fw/toolchain/src/gcc-4.3.3/libssp/ssp.c:70: error: 'O_RDONLY'
> undeclared (first use in this function)
[...]

I assume your host's /bin/sh is not bash.

---------------------------------------------------------------------------

ar9170.fw: fix bashisms while building the cross toolchain.

Signed-off-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>

--- a/toolchain/Makefile
+++ b/toolchain/Makefile
@@ -31,7 +31,8 @@ src/newlib-$(NEWLIB_VER): src/$(NEWLIB_T
 
 src/gcc-$(GCC_VER): src/$(GCC_TAR) src/newlib-$(NEWLIB_VER)
 	tar -C src -xjf $<
-	ln -s $(BASEDIR)/src/newlib-$(NEWLIB_VER)/{newlib,libgloss} $@
+	ln -s $(BASEDIR)/src/newlib-$(NEWLIB_VER)/newlib $@
+	ln -s $(BASEDIR)/src/newlib-$(NEWLIB_VER)/libgloss $@
 
 binutils: src/binutils-$(BINUTILS_VER)
 	mkdir -p build/binutils

---------------------------------------------------------------------------

While you're at it, I'd suggest to bump the versions for the required 
cross-build environment as well, as it noticably improves stability of the 
firmware images built by it (still not perfectly, but better).

---------------------------------------------------------------------------

ar9170.fw: update cross-toolchain.

Updating the toolchain improves stability of the built firmware images 
significantly.

* gcc-4.4.4
* binutils-2.20.1
* newlib 1.18.0

Signed-off-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>

--- a/toolchain/Makefile
+++ b/toolchain/Makefile
@@ -1,12 +1,12 @@
-BINUTILS_VER=2.19.1
+BINUTILS_VER=2.20.1
 BINUTILS_URL=http://mirrors.kernel.org/gnu/binutils/binutils-$(BINUTILS_VER).tar.bz2
 BINUTILS_TAR=binutils-$(BINUTILS_VER).tar.bz2
 
-NEWLIB_VER=1.17.0
+NEWLIB_VER=1.18.0
 NEWLIB_URL=ftp://sources.redhat.com/pub/newlib/newlib-$(NEWLIB_VER).tar.gz
 NEWLIB_TAR=newlib-$(NEWLIB_VER).tar.gz
 
-GCC_VER=4.3.3
+GCC_VER=4.4.4
 GCC_URL=http://mirrors.kernel.org/gnu/gcc/gcc-$(GCC_VER)/gcc-core-$(GCC_VER).tar.bz2
 GCC_TAR=gcc-core-$(GCC_VER).tar.bz2
 
---------------------------------------------------------------------------

Regards
	Stefan Lippers-Hollmann

  reply	other threads:[~2010-05-01  1:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-01  0:15 ar9170-fw David H. Lynch Jr.
2010-05-01  1:23 ` Stefan Lippers-Hollmann [this message]
2010-05-01  5:43   ` ar9170-fw Johannes Berg
2010-05-01  8:38   ` ar9170-fw David H. Lynch Jr.
2010-05-01 10:11   ` ar9170-fw David H. Lynch Jr.
2010-05-01 11:42     ` ar9170-fw Stefan Lippers-Hollmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005010323.53295.s.L-H@gmx.de \
    --to=s.l-h@gmx.de \
    --cc=dhlii@dlasys.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).