linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 4/9] ath9k/htc_drv_main: null dereference typo
@ 2010-05-08 16:23 Dan Carpenter
  2010-05-10  4:38 ` Sujith
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-05-08 16:23 UTC (permalink / raw)
  To: Luis R. Rodriguez
  Cc: Jouni Malinen, Sujith Manoharan, Vasanthakumar Thiagarajan,
	Senthil Balasubramanian, John W. Linville, Vivek Natarajan,
	linux-wireless, ath9k-devel

This is a stray null dereference.  We initialize "ista" properly later on.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index f503586..e75db06 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -461,7 +461,7 @@ static int ath9k_htc_aggr_oper(struct ath9k_htc_priv *priv,
 	struct ath_common *common = ath9k_hw_common(priv->ah);
 	struct ath9k_htc_target_aggr aggr;
 	struct ieee80211_sta *sta = NULL;
-	struct ath9k_htc_sta *ista = (struct ath9k_htc_sta *) sta->drv_priv;
+	struct ath9k_htc_sta *ista;
 	int ret = 0;
 	u8 cmd_rsp;
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [patch 4/9] ath9k/htc_drv_main: null dereference typo
  2010-05-08 16:23 [patch 4/9] ath9k/htc_drv_main: null dereference typo Dan Carpenter
@ 2010-05-10  4:38 ` Sujith
  0 siblings, 0 replies; 2+ messages in thread
From: Sujith @ 2010-05-10  4:38 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Luis Rodriguez, Jouni Malinen, Vasanth Thiagarajan,
	Senthilkumar Balasubramanian, John W. Linville, Vivek Natarajan,
	linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org

Dan Carpenter wrote:
> This is a stray null dereference.  We initialize "ista" properly later on.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Thanks.

Acked-by: Sujith <Sujith.Manoharan@atheros.com>

> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index f503586..e75db06 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -461,7 +461,7 @@ static int ath9k_htc_aggr_oper(struct ath9k_htc_priv *priv,
>  	struct ath_common *common = ath9k_hw_common(priv->ah);
>  	struct ath9k_htc_target_aggr aggr;
>  	struct ieee80211_sta *sta = NULL;
> -	struct ath9k_htc_sta *ista = (struct ath9k_htc_sta *) sta->drv_priv;
> +	struct ath9k_htc_sta *ista;
>  	int ret = 0;
>  	u8 cmd_rsp;
>  

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-10  4:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-08 16:23 [patch 4/9] ath9k/htc_drv_main: null dereference typo Dan Carpenter
2010-05-10  4:38 ` Sujith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).