* [patch 8/9] wl1271: fix notifier interface supported test
@ 2010-05-08 16:25 Dan Carpenter
2010-05-11 4:27 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-05-08 16:25 UTC (permalink / raw)
To: Luciano Coelho
Cc: John W. Linville, Juuso Oikarinen, Teemu Paasikivi, Kalle Valo,
linux-wireless
The "(wl == NULL)" test doesn't work here because "wl" is always
non-null. The intent of the code is to return if the interface
was not supported by the driver.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
index b61cd10..55aa813 100644
--- a/drivers/net/wireless/wl12xx/wl1271_main.c
+++ b/drivers/net/wireless/wl12xx/wl1271_main.c
@@ -852,7 +852,7 @@ static int wl1271_dev_notify(struct notifier_block *me, unsigned long what,
if (wl == wl_temp)
break;
}
- if (wl == NULL)
+ if (wl != wl_temp)
return NOTIFY_DONE;
/* Get the interface IP address for the device. "ifa" will become
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 8/9] wl1271: fix notifier interface supported test
2010-05-08 16:25 [patch 8/9] wl1271: fix notifier interface supported test Dan Carpenter
@ 2010-05-11 4:27 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2010-05-11 4:27 UTC (permalink / raw)
To: ext Dan Carpenter
Cc: John W. Linville, Oikarinen Juuso (Nokia-D/Tampere),
Paasikivi Teemu.3 (EXT-Ixonos/Tampere), Kalle Valo,
linux-wireless@vger.kernel.org
On Sat, 2010-05-08 at 18:25 +0200, ext Dan Carpenter wrote:
> The "(wl == NULL)" test doesn't work here because "wl" is always
> non-null. The intent of the code is to return if the interface
> was not supported by the driver.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
> index b61cd10..55aa813 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c
> @@ -852,7 +852,7 @@ static int wl1271_dev_notify(struct notifier_block *me, unsigned long what,
> if (wl == wl_temp)
> break;
> }
> - if (wl == NULL)
> + if (wl != wl_temp)
> return NOTIFY_DONE;
>
> /* Get the interface IP address for the device. "ifa" will become
Thanks for the fix.
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-11 4:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-08 16:25 [patch 8/9] wl1271: fix notifier interface supported test Dan Carpenter
2010-05-11 4:27 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).