* [patch 6/9] ath5k: several off by one range checks
@ 2010-05-08 16:24 Dan Carpenter
2010-05-08 22:33 ` Bob Copeland
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-05-08 16:24 UTC (permalink / raw)
To: Jiri Slaby
Cc: Nick Kossifidis, Luis R. Rodriguez, Bob Copeland,
John W. Linville, Bruno Randolf, linux-wireless, ath5k-devel
There are several places that use > ARRAY_SIZE() instead of
>= ARRAY_SIZE().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/wireless/ath/ath5k/ani.c b/drivers/net/wireless/ath/ath5k/ani.c
index 584a328..f2311ab 100644
--- a/drivers/net/wireless/ath/ath5k/ani.c
+++ b/drivers/net/wireless/ath/ath5k/ani.c
@@ -73,7 +73,7 @@ ath5k_ani_set_noise_immunity_level(struct ath5k_hw *ah, int level)
const s8 hi[] = { -14, -12 };
const s8 fr[] = { -78, -80 };
#endif
- if (level < 0 || level > ARRAY_SIZE(sz)) {
+ if (level < 0 || level >= ARRAY_SIZE(sz)) {
ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI,
"level out of range %d", level);
return;
@@ -104,7 +104,7 @@ ath5k_ani_set_spur_immunity_level(struct ath5k_hw *ah, int level)
{
const int val[] = { 2, 4, 6, 8, 10, 12, 14, 16 };
- if (level < 0 || level > ARRAY_SIZE(val) ||
+ if (level < 0 || level >= ARRAY_SIZE(val) ||
level > ah->ah_sc->ani_state.max_spur_level) {
ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI,
"level out of range %d", level);
@@ -129,7 +129,7 @@ ath5k_ani_set_firstep_level(struct ath5k_hw *ah, int level)
{
const int val[] = { 0, 4, 8 };
- if (level < 0 || level > ARRAY_SIZE(val)) {
+ if (level < 0 || level >= ARRAY_SIZE(val)) {
ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI,
"level out of range %d", level);
return;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch 6/9] ath5k: several off by one range checks
2010-05-08 16:24 [patch 6/9] ath5k: several off by one range checks Dan Carpenter
@ 2010-05-08 22:33 ` Bob Copeland
2010-05-10 1:18 ` Bruno Randolf
0 siblings, 1 reply; 3+ messages in thread
From: Bob Copeland @ 2010-05-08 22:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez, John W. Linville,
Bruno Randolf, linux-wireless, ath5k-devel
On Sat, May 08, 2010 at 06:24:38PM +0200, Dan Carpenter wrote:
> There are several places that use > ARRAY_SIZE() instead of
> >= ARRAY_SIZE().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks,
Acked-by: Bob Copeland <me@bobcopeland.com>
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 6/9] ath5k: several off by one range checks
2010-05-08 22:33 ` Bob Copeland
@ 2010-05-10 1:18 ` Bruno Randolf
0 siblings, 0 replies; 3+ messages in thread
From: Bruno Randolf @ 2010-05-10 1:18 UTC (permalink / raw)
To: Bob Copeland, Dan Carpenter
Cc: John W. Linville, Bruno Randolf, linux-wireless, ath5k-devel
On Sunday 09 May 2010 07:33:19 you wrote:
> On Sat, May 08, 2010 at 06:24:38PM +0200, Dan Carpenter wrote:
> > There are several places that use > ARRAY_SIZE() instead of
> >
> > >= ARRAY_SIZE().
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Thanks,
> Acked-by: Bob Copeland <me@bobcopeland.com>
ah, yes. found these too, but haven't sent the patch yet.
Acked-by: Bruno Randolf <br1@einfach.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-10 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-08 16:24 [patch 6/9] ath5k: several off by one range checks Dan Carpenter
2010-05-08 22:33 ` Bob Copeland
2010-05-10 1:18 ` Bruno Randolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).