linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruno Randolf <br1@einfach.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
	mcgrof@infradead.org
Subject: Re: [PATCH 2/2] compat-wireless: make patches apply again
Date: Wed, 12 May 2010 17:20:50 +0900	[thread overview]
Message-ID: <201005121720.50514.br1@einfach.org> (raw)
In-Reply-To: <1273526650-26282-2-git-send-email-hauke@hauke-m.de>

On Tuesday 11 May 2010 06:24:10 Hauke Mehrtens wrote:
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  patches/07-change-default-rate-alg.patch |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/patches/07-change-default-rate-alg.patch
> b/patches/07-change-default-rate-alg.patch index af65207..f0ccbce 100644
> --- a/patches/07-change-default-rate-alg.patch
> +++ b/patches/07-change-default-rate-alg.patch
> @@ -21,7 +21,7 @@ at compilation time.
>   module_param(ieee80211_default_rc_algo, charp, 0644);
>   MODULE_PARM_DESC(ieee80211_default_rc_algo,
>   		 "Default rate control algorithm for mac80211 to use");
> -@@ -118,8 +118,8 @@ ieee80211_rate_control_ops_get(const cha
> +@@ -119,8 +119,8 @@ ieee80211_rate_control_ops_get(const cha
>   		ops = 
ieee80211_try_rate_control_ops_get(ieee80211_default_rc_algo);
> 
>   	/* try built-in one if specific alg requested but not found */
> @@ -29,6 +29,6 @@ at compilation time.
>  -		ops = 
ieee80211_try_rate_control_ops_get(CONFIG_MAC80211_RC_DEFAULT);
>  +	if (!ops && strlen(CONFIG_COMPAT_MAC80211_RC_DEFAULT))
>  +		ops =
> ieee80211_try_rate_control_ops_get(CONFIG_COMPAT_MAC80211_RC_DEFAULT); +
> 	kparam_unblock_sysfs_write(ieee80211_default_rc_algo);
> 
>   	return ops;
> - }

this is somehow messed up and doesn't apply. here is a fixed version of the 
patch (not a patch for a patch)...

---

Your current kernels configuration (.config and linux/autoconf.h)
are always respected when compiling external modules. Because
of this if you are using an old kernel which preferred the
PID rate control algorithm we cannot force it to use minstrel
instead. Minstrel is now the default rate control algorithm
and we want you to use it. To let you use it we redefine here
the CONFIG_MAC80211_RC_DEFAULT to CONFIG_COMPAT_MAC80211_RC_DEFAULT
and define CONFIG_COMPAT_MAC80211_RC_DEFAULT on config.mk.
Through the compat autoconf we then get it also defined there
at compilation time.

--- a/net/mac80211/rate.c	2010-05-12 16:27:02.245747971 +0900
+++ b/net/mac80211/rate.c	2010-05-12 17:00:45.855748158 +0900
@@ -23,7 +23,7 @@
 static LIST_HEAD(rate_ctrl_algs);
 static DEFINE_MUTEX(rate_ctrl_mutex);
 
-static char *ieee80211_default_rc_algo = CONFIG_MAC80211_RC_DEFAULT;
+static char *ieee80211_default_rc_algo = CONFIG_COMPAT_MAC80211_RC_DEFAULT;
 module_param(ieee80211_default_rc_algo, charp, 0644);
 MODULE_PARM_DESC(ieee80211_default_rc_algo,
 		 "Default rate control algorithm for mac80211 to use");
@@ -118,8 +118,8 @@
 		ops = ieee80211_try_rate_control_ops_get(ieee80211_default_rc_algo);
 
 	/* try built-in one if specific alg requested but not found */
-	if (!ops && strlen(CONFIG_MAC80211_RC_DEFAULT))
-		ops = ieee80211_try_rate_control_ops_get(CONFIG_MAC80211_RC_DEFAULT);
+	if (!ops && strlen(CONFIG_COMPAT_MAC80211_RC_DEFAULT))
+		ops = 
ieee80211_try_rate_control_ops_get(CONFIG_COMPAT_MAC80211_RC_DEFAULT);
 
 	return ops;
 }

  reply	other threads:[~2010-05-12  8:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 21:24 [PATCH 1/2] compat-wireless: backport pm_qos_{add,remove,update}_request Hauke Mehrtens
2010-05-10 21:24 ` [PATCH 2/2] compat-wireless: make patches apply again Hauke Mehrtens
2010-05-12  8:20   ` Bruno Randolf [this message]
2010-05-12 16:28     ` Luis R. Rodriguez
2010-05-13  1:00       ` Bruno Randolf
2010-05-13  1:06         ` Luis R. Rodriguez
2010-05-10 22:24 ` [PATCH 1/2] compat-wireless: backport pm_qos_{add,remove,update}_request Luis R. Rodriguez
  -- strict thread matches above, loose matches on Subject: below --
2010-10-18 20:36 [PATCH 1/2] compat-wireless: backport sock_recv_ts_and_drops in compat Hauke Mehrtens
2010-10-18 20:36 ` [PATCH 2/2] compat-wireless: make patches apply again Hauke Mehrtens
2011-04-07 14:39 [PATCH 1/2] compat-wireless: Remove extra config option for kfifo Hauke Mehrtens
2011-04-07 14:39 ` [PATCH 2/2] compat-wireless: make patches apply again Hauke Mehrtens
2011-04-15  0:56   ` Luis R. Rodriguez
2011-11-24 19:47 [PATCH 1/2] compat-wireless: add config var for CORDIC and CRC8 Hauke Mehrtens
2011-11-24 19:47 ` [PATCH 2/2] compat-wireless: make patches apply again Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005121720.50514.br1@einfach.org \
    --to=br1@einfach.org \
    --cc=hauke@hauke-m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    --cc=mcgrof@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).