Re: [PATCH] Fix AR9285 always turn off LED on HP mini 210 [1/1]

Re: [PATCH] Fix AR9285 always turn off LED on HP mini 210 [1/1]

[Luis R. Rodriguez]

On Thu, May 13, 2010 at 04:13:18AM -0700, Matt Chen wrote:
> Hi Luis,
> Tried the driver,compat-wireless-2.6.33.
> 2.tar.bz2,  from http://wireless.kernel.org/en/users/Download/stable, it doesn't fix this issue. The LED is still keeping off whatever you enable/disable it.

2.6.33 is ancient now, try the compat-wireles 2.6.34-rc stuff and if
that doesn't help try bleeding edge. The fixes need to be addressed
on bleedinge edge *first* but if bleedinge edge already has a fix
then its a matter of cherry picking that and sending it to the stable
gods.

  Luis

Re: [PATCH] Fix AR9285 always turn off LED on HP mini 210 [1/1]

[Joey Lee]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

Hi Luis, 

Could you help kindly review my attahced patch (the same with my first
mail in this loop)?

Per our testing, this patch can fix the LED problem on HP mini 210, but
we are not good for wifi driver and just trace the LED behavior. We need
your professional suggestion to us.


thank's a lot!
Joey Lee

於 二，2010-05-18 於 09:55 +0800，Matt Chen 提到：
> Hi Luis,
> After testing the compat-wireless-2.6.34-rc4.tar.bz2，this issue is
> still.
> The wireless LED is always off no matter how many times I try to press
> the function key to enable/disable the wireless.
> I would like to ask is there a way to debug it ? 
> Thanks ~ ;-)
> 
> 2010/5/14 Luis R. Rodriguez <lrodriguez@atheros.com>
>         On Thu, May 13, 2010 at 04:13:18AM -0700, Matt Chen wrote:
>         > Hi Luis,
>         > Tried the driver,compat-wireless-2.6.33.
>         > 2.tar.bz2,  from
>         http://wireless.kernel.org/en/users/Download/stable, it
>         doesn't fix this issue. The LED is still keeping off whatever
>         you enable/disable it.
>         
>         
>         2.6.33 is ancient now, try the compat-wireles 2.6.34-rc stuff
>         and if
>         that doesn't help try bleeding edge. The fixes need to be
>         addressed
>         on bleedinge edge *first* but if bleedinge edge already has a
>         fix
>         then its a matter of cherry picking that and sending it to the
>         stable
>         gods.
>         
>          Luis
> 
> 
> 
> -- 
> Matt Chen
> Engineer
> Novell Asia Pacific
> Tel : +886- 2- 27370946 ext 507
> Fax : +886- 2- 27370947
> Novell Making IT Work As One


[-- Attachment #2: 0001-Fix-AR9285-always-turn-off-LED-on-HP-mini-210.patch --]
[-- Type: text/plain, Size: 1726 bytes --]

>From b725acf8fda0866aab49807a93c925e07994e2a4 Mon Sep 17 00:00:00 2001
From: Lee, Chun-Yi <jlee@novell.com>
Date: Sun, 9 May 2010 06:47:07 +0800
Subject: [PATCH] Fix AR9285 always turn off LED on HP mini 210

On 2.6.33 kernel, The AR9285 wifi module always turn off wifi LED
on fn+f11 function key on HP  mini 210.
After trace main.c, found it was always disable_radio after call
ath9k_config because the all_wiphys_idle is true on HP mini 210.

This LED works fine on 2.6.32 kernel, the following patch causes
this side effect:
ath9k: fix listening to idle requests
194b7c13b4c516db94db8ee004342f8935922739

Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
---
 drivers/net/wireless/ath/ath9k/main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 643bea3..d4ca82e 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -2704,6 +2704,9 @@ static int ath9k_config(struct ieee80211_hw *hw, u32 changed)
 		if (!idle && all_wiphys_idle)
 			enable_radio = true;
 
+		if (idle && all_wiphys_idle)
+			disable_radio = true;
+
 		/*
 		 * After we unlock here its possible another wiphy
 		 * can be re-renabled so to account for that we will
@@ -2804,10 +2807,6 @@ skip_chan_change:
 	if (changed & IEEE80211_CONF_CHANGE_POWER)
 		sc->config.txpowlimit = 2 * conf->power_level;
 
-	spin_lock_bh(&sc->wiphy_lock);
-	disable_radio = ath9k_all_wiphys_idle(sc);
-	spin_unlock_bh(&sc->wiphy_lock);
-
 	if (disable_radio) {
 		ath_print(common, ATH_DBG_CONFIG, "idle: disabling radio\n");
 		ath_radio_disable(sc, hw);
-- 
1.6.0.2