From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath9k: Make sure null func frame is acked before going into PS for ar9003
Date: Sat, 22 May 2010 23:29:04 -0700 [thread overview]
Message-ID: <20100523062902.GA21298@vasanth-laptop> (raw)
In-Reply-To: <877hmvixp1.fsf@purkki.valot.fi>
On Sun, May 23, 2010 at 12:13:54AM +0530, Kalle Valo wrote:
> Vasanthakumar Thiagarajan <vasanth@atheros.com> writes:
>
> > Add missing code to handle nullfunc frame completion in
> > ath_tx_edma_tasklet().
>
> [...]
>
> > + /*
> > + * Make sure null func frame is acked before configuring
> > + * hw into ps mode.
> > + */
> > + if (bf->bf_isnullfunc && txok) {
> > + if ((sc->ps_flags & PS_ENABLED))
> > + ath9k_enable_ps(sc);
> > + else
> > + sc->ps_flags |= PS_NULLFUNC_COMPLETED;
> > + }
>
> Few months ago a similar test was added to mac80211. Why does ath9k
> need this also in the driver?
>
Right, but this patch is needed unless the logic which checks for
completion of null func in driver is cleaned up. I'll do this clean
up later. thanks.
Vasanth
prev parent reply other threads:[~2010-05-23 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 1:57 [PATCH 1/3] ath9k: Make sure null func frame is acked before going into PS for ar9003 Vasanthakumar Thiagarajan
2010-05-18 1:57 ` [PATCH 2/3] ath9k: Fix power save with auto sleeping Vasanthakumar Thiagarajan
2010-05-18 1:57 ` [PATCH 3/3] ath9k_hw: Enable auto sleep for ar9003 Vasanthakumar Thiagarajan
2010-05-22 18:43 ` [PATCH 1/3] ath9k: Make sure null func frame is acked before going into PS " Kalle Valo
2010-05-23 6:29 ` Vasanthakumar Thiagarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523062902.GA21298@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox