From: "John W. Linville" <linville@tuxdriver.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-wireless@vger.kernel.org, mcgrof@gmail.com
Subject: Re: [PATCH]wireless:ath9k Disable leds for Apple products.
Date: Wed, 26 May 2010 13:18:45 -0400 [thread overview]
Message-ID: <20100526171844.GB5823@tuxdriver.com> (raw)
In-Reply-To: <1274894056-2866-2-git-send-email-justinmattock@gmail.com>
On Wed, May 26, 2010 at 10:14:16AM -0700, Justin P. Mattock wrote:
> Disable the leds on ath9k for Apple products, since
> there is no leds on any of there machines(or non that I can find!!).
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> void ath_init_leds(struct ath_softc *sc)
> {
> char *trigger;
> int ret;
>
> + /* Apple has no leds lights for their wireless. */
> + if (dmi_check_system(dmi_system_table) > 0)
> + return -ENODEV;
> + else
> +
> if (AR_SREV_9287(sc->sc_ah))
> sc->sc_ah->led_pin = ATH_LED_PIN_9287;
> else
Surely we don't need the 'else'.
Does enabling the LEDs on these systems cause any problems?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-05-26 17:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 17:14 [PATCH]wireless:ath9k Fix ath_print in xmit.c Justin P. Mattock
2010-05-26 17:14 ` [PATCH]wireless:ath9k Disable leds for Apple products Justin P. Mattock
2010-05-26 17:18 ` John W. Linville [this message]
2010-05-26 17:38 ` Justin P. Mattock
2010-05-26 21:05 ` Luis R. Rodriguez
2010-05-26 21:34 ` Justin P. Mattock
2010-05-26 21:42 ` Luis R. Rodriguez
2010-05-26 22:28 ` Justin P. Mattock
2010-05-26 17:19 ` Luis R. Rodriguez
2010-05-26 17:16 ` [PATCH]wireless:ath9k Fix ath_print in xmit.c Luis R. Rodriguez
2010-05-26 17:28 ` Arnd Hannemann
2010-05-26 17:49 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526171844.GB5823@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=justinmattock@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).