Commit 6b5d11 breaks association with WPA enabled APs

[Tobias Doerffel <tobias.doerffel@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 3277 bytes --]

Hi,

using the latest kernel (Linus master branch) breaks my wireless connection 
(ath5k/AR5001), i.e. I'm not able to connect to my WPA-secured AP anymore. 
It's been working fine up to (and including) 2.6.34.

Verbose output of wpa_supplicant:

Selecting BSS from priority group 0
Try to find WPA-enabled AP
0: 00:XX:XX:XX:XX:c6 ssid='myAP' wpa_ie_len=0 rsn_ie_len=20 caps=0x11
   skip - SSID mismatch
   selected based on RSN IE
   selected WPA AP 00:XX:11:XX:XX:c6 ssid='myAP'
Trying to associate with 00:XX:XX:XX:XX:c6 (SSID='myAP' freq=2462 MHz)
Cancelling scan request
WPA: clearing own WPA/RSN IE
Automatic auth_alg selection: 0x1
RSN: using IEEE 802.11i/D9.0
WPA: Selected cipher suites: group 16 pairwise 16 key_mgmt 2 proto 2
WPA: clearing AP WPA IE
WPA: set AP RSN IE - hexdump(len=22): 30 14 01 00 00 0f ac 04 01 00 00 0f ac 
04 01 00 00 0f ac 02 00 00
WPA: using GTK CCMP
WPA: using PTK CCMP
WPA: using KEY_MGMT WPA-PSK
WPA: not using MGMT group cipher
WPA: Set own WPA IE default - hexdump(len=22): 30 14 01 00 00 0f ac 04 01 00 
00 0f ac 04 01 00 00 0f ac 02 00 00
No keys have been configured - skip key clearing
wpa_driver_wext_set_drop_unencrypted
State: SCANNING -> ASSOCIATING
wpa_driver_wext_set_operstate: operstate 0->0 (DORMANT)
WEXT: Operstate: linkmode=-1, operstate=5
wpa_driver_wext_associate
wpa_driver_wext_set_psk
Setting authentication timeout: 10 sec 0 usec
EAPOL: External notification - EAP success=0
EAPOL: External notification - EAP fail=0
EAPOL: External notification - portControl=Auto
RSN: Ignored PMKID candidate without preauth flag
RTM_NEWLINK: operstate=0 ifi_flags=0x1003 ([UP])
RTM_NEWLINK, IFLA_IFNAME: Interface 'wlan0' added
Wireless event: cmd=0x8b06 len=8
RTM_NEWLINK: operstate=0 ifi_flags=0x1003 ([UP])
RTM_NEWLINK, IFLA_IFNAME: Interface 'wlan0' added
Wireless event: cmd=0x8b04 len=12
RTM_NEWLINK: operstate=0 ifi_flags=0x1003 ([UP])
RTM_NEWLINK, IFLA_IFNAME: Interface 'wlan0' added
Wireless event: cmd=0x8b1a len=15

[delay of some seconds]

Authentication with 00:XX:X:XX:XX:c6 timed out.
Added BSSID 00:XX:XX:XX:XX:c6 into blacklist
No keys have been configured - skip key clearing
State: ASSOCIATING -> DISCONNECTED
wpa_driver_wext_set_operstate: operstate 0->0 (DORMANT)
WEXT: Operstate: linkmode=-1, operstate=5
EAPOL: External notification - portEnabled=0
EAPOL: External notification - portValid=0
EAPOL: External notification - EAP success=0
Setting scan request: 0 sec 0 usec
State: DISCONNECTED -> SCANNING
Starting AP scan (broadcast SSID)
Scan requested (ret=0) - scan timeout 30 seconds
RTM_NEWLINK: operstate=0 ifi_flags=0x1003 ([UP])
RTM_NEWLINK, IFLA_IFNAME: Interface 'wlan0' added
Wireless event: cmd=0x8b19 len=8
Received 3379 bytes of scan results (10 BSSes)
New scan results available
Selecting BSS from priority group 2
Try to find WPA-enabled AP
...

and the whole procedure starts over and over again. I therefore started to 
bisect the issue and finally was able to blame commit 
6b5d117eddc09cd976ad8030d715f4350f598a22 ("ath5k: clean up queue 
manipulation"). After reverting the commit on-top of my branch, everything 
works fine again! So please have a look at it and/or revert the commit.

Regards

Toby

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]