From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Greg KH <greg@kroah.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [stable] [PATCH] ath5k: drop warning on jumbo frames
Date: Thu, 3 Jun 2010 15:49:12 -0700 [thread overview]
Message-ID: <20100603224912.GK2318@tux> (raw)
In-Reply-To: <20100603220947.GA22595@kroah.com>
On Thu, Jun 03, 2010 at 03:09:47PM -0700, Greg KH wrote:
> On Mon, May 10, 2010 at 03:26:27PM -0400, Luis R. Rodriguez wrote:
> > Jumbo frames are not supported, and if they are seen it is likely
> > a bogus frame so just silently discard them instead of warning on
> > them all time. Also, instead of dropping them immediately though
> > move the check *after* we check for all sort of frame errors. This
> > should enable us to discard these frames if the hardware picks
> > other bogus items first. Lets see if we still get those jumbo
> > counters increasing still with this.
> >
> > Jumbo frames would happen if we tell hardware we can support
> > a small 802.11 chunks of DMA'd frame, hardware would split RX'd
> > frames into parts and we'd have to reconstruct them in software.
> > This is done with USB due to the bulk size but with ath5k we
> > already provide a good limit to hardware and this should not be
> > happening.
> >
> > This is reported quite often and if it fills the logs then this
> > needs to be addressed and to avoid spurious reports.
> >
> > Cc: stable@kernel.org
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> > drivers/net/wireless/ath/ath5k/base.c | 12 ++++++------
>
> This is now upstream, but doesn't seem to apply to any of the .32, .33,
> or .34 trees. If you want it there, please send me a backported version
> of it.
Thanks Greg. I cannot address this right now so I've stashed it here:
http://wireless.kernel.org/en/developers/stable-pending
If anyone has free time please feel free to address the backport and
any other listed above (just one more).
Luis
prev parent reply other threads:[~2010-06-03 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 19:26 [PATCH] ath5k: drop warning on jumbo frames Luis R. Rodriguez
2010-06-03 22:09 ` [stable] " Greg KH
2010-06-03 22:49 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603224912.GK2318@tux \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).