linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Subject: [RFC 05/21] mac80211: common work skb freeing
Date: Mon, 07 Jun 2010 13:01:38 +0200	[thread overview]
Message-ID: <20100607110159.849145960@sipsolutions.net> (raw)
In-Reply-To: 20100607110133.472649120@sipsolutions.net

From: Johannes Berg <johannes.berg@intel.com>

All the management processing functions free the
skb after they are done, so this can be done in
the new common code instead.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/mac80211/ibss.c  |    2 --
 net/mac80211/iface.c |    3 ++-
 net/mac80211/mesh.c  |    2 --
 net/mac80211/mlme.c  |    5 +----
 4 files changed, 3 insertions(+), 9 deletions(-)

--- wireless-testing.orig/net/mac80211/ibss.c	2010-06-01 10:19:39.000000000 +0200
+++ wireless-testing/net/mac80211/ibss.c	2010-06-01 10:19:40.000000000 +0200
@@ -754,8 +754,6 @@ void ieee80211_ibss_rx_queued_mgmt(struc
 		ieee80211_rx_mgmt_auth_ibss(sdata, mgmt, skb->len);
 		break;
 	}
-
-	kfree_skb(skb);
 }
 
 void ieee80211_ibss_work(struct ieee80211_sub_if_data *sdata)
--- wireless-testing.orig/net/mac80211/mesh.c	2010-06-01 10:19:39.000000000 +0200
+++ wireless-testing/net/mac80211/mesh.c	2010-06-01 10:19:40.000000000 +0200
@@ -620,8 +620,6 @@ void ieee80211_mesh_rx_queued_mgmt(struc
 		ieee80211_mesh_rx_mgmt_action(sdata, mgmt, skb->len, rx_status);
 		break;
 	}
-
-	kfree_skb(skb);
 }
 
 void ieee80211_mesh_work(struct ieee80211_sub_if_data *sdata)
--- wireless-testing.orig/net/mac80211/mlme.c	2010-06-01 10:19:39.000000000 +0200
+++ wireless-testing/net/mac80211/mlme.c	2010-06-01 10:19:40.000000000 +0200
@@ -1754,7 +1754,7 @@ void ieee80211_sta_rx_queued_mgmt(struct
 		default:
 			WARN(1, "unexpected: %d", rma);
 		}
-		goto out;
+		return;
 	}
 
 	mutex_unlock(&ifmgd->mtx);
@@ -1762,9 +1762,6 @@ void ieee80211_sta_rx_queued_mgmt(struct
 	if (skb->len >= 24 + 2 /* mgmt + deauth reason */ &&
 	    (fc & IEEE80211_FCTL_STYPE) == IEEE80211_STYPE_DEAUTH)
 		cfg80211_send_deauth(sdata->dev, (u8 *)mgmt, skb->len);
-
- out:
-	kfree_skb(skb);
 }
 
 static void ieee80211_sta_timer(unsigned long data)
--- wireless-testing.orig/net/mac80211/iface.c	2010-06-01 10:19:39.000000000 +0200
+++ wireless-testing/net/mac80211/iface.c	2010-06-01 10:19:40.000000000 +0200
@@ -738,9 +738,10 @@ static void ieee80211_iface_work(struct
 			break;
 		default:
 			WARN(1, "frame for unexpected interface type");
-			kfree_skb(skb);
 			break;
 		}
+
+		kfree_skb(skb);
 	}
 
 	/* then other type-dependent work */



  parent reply	other threads:[~2010-06-07 11:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 11:01 [RFC 00/21] sleeping ampdu_action Johannes Berg
2010-06-07 11:01 ` [RFC 01/21] mac80211: simplify station/aggregation code Johannes Berg
2010-06-07 11:01 ` [RFC 02/21] mac80211: use common skb queue Johannes Berg
2010-06-07 11:01 ` [RFC 03/21] mac80211: use common work struct Johannes Berg
2010-06-07 11:01 ` [RFC 04/21] mac80211: use common work function Johannes Berg
2010-06-07 11:01 ` Johannes Berg [this message]
2010-06-07 11:01 ` [RFC 06/21] mac80211: pull mgmt frame rx into rx handler Johannes Berg
2010-06-07 11:01 ` [RFC 07/21] mac80211: always process blockack action from workqueue Johannes Berg
2010-06-07 11:01 ` [RFC 08/21] mac80211: move blockack stop due to fragmentation Johannes Berg
2010-06-07 11:01 ` [RFC 09/21] mac80211: move aggregation callback processing Johannes Berg
2010-06-07 11:01 ` [RFC 10/21] mac80211: use RCU for RX aggregation Johannes Berg
2010-06-07 11:01 ` [RFC 11/21] mac80211: use RCU for TX aggregation Johannes Berg
2010-06-07 11:01 ` [RFC 12/21] mac80211: remove non-irqsafe aggregation callbacks Johannes Berg
2010-06-07 11:01 ` [RFC 13/21] mac80211: refcount aggregation queue stop Johannes Berg
2010-06-07 11:01 ` [RFC 14/21] mac80211: make TX aggregation start/stop request async Johannes Berg
2010-06-07 11:01 ` [RFC 15/21] mac80211: move BA session work Johannes Berg
2010-06-07 11:01 ` [RFC 16/21] mac80211: defer RX agg session teardown to work Johannes Berg
2010-06-07 11:01 ` [RFC 17/21] mac80211: fix RX aggregation timer Johannes Berg
2010-06-07 11:01 ` [RFC 18/21] mac80211: change RX aggregation locking Johannes Berg
2010-06-07 11:01 ` [RFC 19/21] mac80211: defer TX agg session teardown to work Johannes Berg
2010-06-07 11:01 ` [RFC 20/21] mac80211: change TX aggregation locking Johannes Berg
2010-06-07 11:01 ` [RFC 21/21] mac80211: allow drivers to sleep in ampdu_action Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100607110159.849145960@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).