From: Bruno Randolf <br1@einfach.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/3] cfg80211: Add nl80211 antenna configuration
Date: Tue, 8 Jun 2010 10:19:10 +0900 [thread overview]
Message-ID: <201006081019.10217.br1@einfach.org> (raw)
In-Reply-To: <1275901408.3639.2.camel@jlt3.sipsolutions.net>
On Monday 07 June 2010 18:03:28 you wrote:
> On Mon, 2010-06-07 at 15:58 +0900, Bruno Randolf wrote:
> > +static int nl80211_get_antenna(struct sk_buff *skb, struct genl_info
> > *info) +{
> > + struct cfg80211_registered_device *rdev;
> > + struct sk_buff *msg;
> > + void *hdr;
> > + int res;
> > + u8 tx_ant, rx_ant;
>
> You should probably set them both to 0 here,
ok.
> > + res = rdev->ops->get_antenna(&rdev->wiphy, &tx_ant, &rx_ant);
> > + if (res)
> > + goto free_msg;
>
> and complain about the driver if they still are after this.
would that be a WARN_ON?
thanks,
bruno
next prev parent reply other threads:[~2010-06-08 1:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 6:58 [PATCH v3 1/3] cfg80211: Add nl80211 antenna configuration Bruno Randolf
2010-06-07 6:59 ` [PATCH v3 2/3] mac80211: Add " Bruno Randolf
2010-06-07 6:59 ` [PATCH v3 3/3] ath5k: Add support for " Bruno Randolf
2010-06-07 9:03 ` [PATCH v3 1/3] cfg80211: Add nl80211 " Johannes Berg
2010-06-08 1:19 ` Bruno Randolf [this message]
2010-06-08 7:27 ` Johannes Berg
2010-06-07 9:05 ` Johannes Berg
2010-06-08 1:10 ` Bruno Randolf
2010-06-08 9:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006081019.10217.br1@einfach.org \
--to=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).